Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transform] update reset resets to old max_page_search_size #56499

Closed
hendrikmuhs opened this issue May 11, 2020 · 1 comment · Fixed by #57648
Closed

[Transform] update reset resets to old max_page_search_size #56499

hendrikmuhs opened this issue May 11, 2020 · 1 comment · Fixed by #57648
Labels
>bug :ml/Transform Transform

Comments

@hendrikmuhs
Copy link

The move of max_page_search_size in #56007 has a side-effect. If you have an old config, update max_page_search_size, update it again and reset it to the default, it resets to the old configs max_page_search_size instead of resetting it to the default.

_update should always rewrite the config to the newest version and therefore move max_page_search_size to the new place.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml/Transform)

@hendrikmuhs hendrikmuhs mentioned this issue Jun 4, 2020
Merged
hendrikmuhs pushed a commit that referenced this issue Jun 4, 2020
[Transform] improve update API (#57648)
3ab4dd9 
rewrite config on update if either version is outdated, credentials change,
the update changes the config or deprecated settings are found. Deprecated
settings get migrated to the new format. The upgrade can be easily extended to
do any necessary re-writes.

fixes #56499
hendrikmuhs pushed a commit to hendrikmuhs/elasticsearch that referenced this issue Jun 4, 2020
[Transform] improve update API (elastic#57648)
f1ff38e 
rewrite config on update if either version is outdated, credentials change,
the update changes the config or deprecated settings are found. Deprecated
settings get migrated to the new format. The upgrade can be easily extended to
do any necessary re-writes.

fixes elastic#56499
hendrikmuhs pushed a commit to hendrikmuhs/elasticsearch that referenced this issue Jun 4, 2020
[Transform] improve update API (elastic#57648)
0872f36 
rewrite config on update if either version is outdated, credentials change,
the update changes the config or deprecated settings are found. Deprecated
settings get migrated to the new format. The upgrade can be easily extended to
do any necessary re-writes.

fixes elastic#56499
This was referenced Jun 4, 2020
Merged
Merged
hendrikmuhs pushed a commit that referenced this issue Jun 5, 2020
[7.x][Transform] improve update API (#57685)
c1c8817 
rewrite config on update if either version is outdated, credentials change,
the update changes the config or deprecated settings are found. Deprecated
settings get migrated to the new format. The upgrade can be easily extended to
do any necessary re-writes.

fixes #56499
backport #57648
hendrikmuhs pushed a commit that referenced this issue Jun 24, 2020
[7.8][Transform] improve update API (#57686)
2d5ba33 
rewrite config on update if either version is outdated, credentials change, the
update changes the config or deprecated settings are found. Deprecated settings
get migrated to the new format. The upgrade can be easily extended to do any
necessary re-writes.

fixes #56499
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug :ml/Transform Transform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Transform] improve update API hendrikmuhs/elasticsearch
2 participants
@hendrikmuhs @elasticmachine