Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prefer_v2_templates flag on indexing operations #56528

Closed
dakrone opened this issue May 11, 2020 · 1 comment · Fixed by #56546
Closed

Remove prefer_v2_templates flag on indexing operations #56528

dakrone opened this issue May 11, 2020 · 1 comment · Fixed by #56546
Assignees
@dakrone
Labels
blocker >bug :Data Management/Indices APIs APIs to create and manage indices and templates Team:Data Management Meta label for data/management team

Comments

@dakrone
Copy link
Member

dakrone commented May 11, 2020

After careful decision we decided to remove the ?prefer_v2_templates flag introduced in #55411, instead we will consider addition of a V2 index template opting into the newer behavior.

To that end, we need to remove all the cases of the prefer_v2_templates query string parameter and its effect from the 7.8+ code.
@dakrone dakrone added >bug :Data Management/Indices APIs APIs to create and manage indices and templates labels May 11, 2020
@dakrone dakrone self-assigned this May 11, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Indices APIs)

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label May 11, 2020
@dakrone dakrone mentioned this issue May 11, 2020
Closed
dakrone added a commit to dakrone/elasticsearch that referenced this issue May 11, 2020
@dakrone
Remove prefer_v2_templates query string parameter
2928daf 
This commit removes the `prefer_v2_templates` flag and setting. This was a brief setting that
allowed specifying whether V1 or V2 template should be used when an index is created. It has been
removed in favor of V2 templates always having priority.

Relates to elastic#53101
Resolves elastic#56528

This is not a breaking change because this flag was never in a released version.
@dakrone dakrone mentioned this issue May 11, 2020
Merged
dakrone added a commit to dakrone/elasticsearch that referenced this issue May 11, 2020
@dakrone
Remove prefer_v2_templates query string parameter
9675bd0 
This commit removes the `prefer_v2_templates` flag and setting. This was a brief setting that
allowed specifying whether V1 or V2 template should be used when an index is created. It has been
removed in favor of V2 templates always having priority.

Relates to elastic#53101
Resolves elastic#56528

This is not a breaking change because this flag was never in a released version.
@dakrone dakrone mentioned this issue May 11, 2020
Merged
dakrone added a commit to dakrone/elasticsearch that referenced this issue May 11, 2020
@dakrone
Remove prefer_v2_templates query string parameter
cb27623 
This commit removes the `prefer_v2_templates` flag and setting. This was a brief setting that
allowed specifying whether V1 or V2 template should be used when an index is created. It has been
removed in favor of V2 templates always having priority.

Relates to elastic#53101
Resolves elastic#56528

This is not a breaking change because this flag was never in a released version.
@dakrone dakrone mentioned this issue May 11, 2020
Merged
@ph ph mentioned this issue May 11, 2020
Closed
dakrone added a commit that referenced this issue May 11, 2020
@dakrone
Remove prefer_v2_templates query string parameter (#56541)
9d6625a 
This commit removes the `prefer_v2_templates` flag and setting. This was a brief setting that
allowed specifying whether V1 or V2 template should be used when an index is created. It has been
removed in favor of V2 templates always having priority.

Relates to #53101
Resolves #56528

This is not a breaking change because this flag was never in a released version.
dakrone added a commit that referenced this issue May 11, 2020
@dakrone
Remove prefer_v2_templates query string parameter (#56545)
1337b35 
This commit removes the `prefer_v2_templates` flag and setting. This was a brief setting that
allowed specifying whether V1 or V2 template should be used when an index is created. It has been
removed in favor of V2 templates always having priority.

Relates to #53101
Resolves #56528

This is not a breaking change because this flag was never in a released version.
dakrone added a commit that referenced this issue May 11, 2020
@dakrone
Remove prefer_v2_templates query string parameter (#56546)
fc708cc 
This commit removes the `prefer_v2_templates` flag and setting. This was a brief setting that
allowed specifying whether V1 or V2 template should be used when an index is created. It has been
removed in favor of V2 templates always having priority.

Relates to #53101
Resolves #56528

This is not a breaking change because this flag was never in a released version.
@urso urso mentioned this issue May 12, 2020
Closed
@jalvz jalvz mentioned this issue May 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dakrone dakrone

Labels
blocker >bug :Data Management/Indices APIs APIs to create and manage indices and templates Team:Data Management Meta label for data/management team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove prefer_v2_templates query string parameter dakrone/elasticsearch
2 participants
@dakrone @elasticmachine