Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup Action must throw exception when rollup index already exists #65769

Closed
talevy opened this issue Dec 2, 2020 · 1 comment · Fixed by #85708
Closed

Rollup Action must throw exception when rollup index already exists #65769

talevy opened this issue Dec 2, 2020 · 1 comment · Fixed by #85708
Assignees
@csoulios
Labels
>non-issue :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@talevy
Copy link
Contributor

talevy commented Dec 2, 2020

Currently, the Rollup Action defined in #64900 does not have safeguards against the API running on anything other than an existing-non-rollup-index as the source index, and a rollup-index that does not exist yet.

If rollup index already exists, an exception should be thrown.

relates #42720.
@talevy talevy added >non-issue :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Dec 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@talevy talevy mentioned this issue Dec 2, 2020
Closed
21 tasks
@csoulios csoulios self-assigned this Feb 4, 2022
@csoulios csoulios mentioned this issue Apr 15, 2022
Merged
csoulios added a commit to csoulios/elasticsearch that referenced this issue Apr 18, 2022
@csoulios
Added validations for rollup request parameters
a3e3e42 
Clean up handling of the temporary index name
Fixes elastic#65769
csoulios added a commit that referenced this issue May 25, 2022
@csoulios
TSDB: Implement downsampling on time-series indices (#85708)
d539957 
This PR implements downsampling operation on time series indices.

The PR creates a _rollup endpoint that allows users to downsample an index and can be
accessed by the following call:

POST /<source_index>/_rollup/<rollup_index>
{
    "fixed_interval": "1d"
}

Requirements

An index can be downsampled if all of the following requirements are met:

    Must be a time series index (have the index.mode: time_series index setting)
    Must not be writeable (have the index.blocks.write: true index setting)
    Must have dimension fields marked with mapping parameter time_series_dimension: true
    Must have metric fields marked with mapping parameter time_series_metric

Relates to #74660

Fixes #65769
Fixes #69799
Finally, this PR is based on the code written for #64900
salvatore-campagna pushed a commit to salvatore-campagna/elasticsearch that referenced this issue May 26, 2022
@csoulios @salvatore-campagna
TSDB: Implement downsampling on time-series indices (elastic#85708)
4175d39 
This PR implements downsampling operation on time series indices.

The PR creates a _rollup endpoint that allows users to downsample an index and can be
accessed by the following call:

POST /<source_index>/_rollup/<rollup_index>
{
    "fixed_interval": "1d"
}

Requirements

An index can be downsampled if all of the following requirements are met:

    Must be a time series index (have the index.mode: time_series index setting)
    Must not be writeable (have the index.blocks.write: true index setting)
    Must have dimension fields marked with mapping parameter time_series_dimension: true
    Must have metric fields marked with mapping parameter time_series_metric

Relates to elastic#74660

Fixes elastic#65769
Fixes elastic#69799
Finally, this PR is based on the code written for elastic#64900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csoulios csoulios

Labels
>non-issue :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TSDB: Implement downsampling on time-series indices csoulios/elasticsearch
3 participants
@talevy @csoulios @elasticmachine