Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Use INTEG_TEST distribution in FIPS 140 testing when possible #70005

Closed
jkakavas opened this issue Mar 5, 2021 · 5 comments · Fixed by #91101
Closed

[CI] Use INTEG_TEST distribution in FIPS 140 testing when possible #70005

jkakavas opened this issue Mar 5, 2021 · 5 comments · Fixed by #91101
Assignees
Labels
:Security/FIPS Running ES in FIPS 140-2 mode Team:Security Meta label for security team

Comments

@jkakavas
Copy link
Member

jkakavas commented Mar 5, 2021

In #64024 , we changed our test setup for FIPS 140 to always use the default distribution because we always wanted to set xpack.security.fips_mode.enabled: true and we can't do this with INTEG_TEST distribution as in tests for non-xpack modules, that setting is not available.

We should try to refrain from setting a specific distribution in fips and use INTEG_TEST as much as possible ( to the extent that the test suites themselves already use it). This has two benefits:

This issue is for tracking the problem so that we can schedule for the appropriate time for investigation and come up with a proposal on how to do this.

@jkakavas jkakavas added the :Security/FIPS Running ES in FIPS 140-2 mode label Mar 5, 2021
@elasticmachine elasticmachine added the Team:Security Meta label for security team label Mar 5, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@ywangd
Copy link
Member

ywangd commented Mar 5, 2021

I don't fully understand the conversation in #66820. But is the proposal to just allow extra xpack settings but make them no-op? If so, why don't we just stop running FIPS for these tests at all? Also, FIPS is a bit of a cross-cutting mode. So even if a test does not seem to use it directly, is it possible that they would still fail in FIPS mode? A not-great example is the md5 hasher used for fingerprint ingestion processor. I know md5 is still allowed by BC-FIPS, but assume it is not. If it uses the INTEG_TEST distribution, the test will not catch this issue?

@jkakavas
Copy link
Member Author

jkakavas commented Mar 5, 2021

But is the proposal to just allow extra xpack settings but make them no-op? If so, why don't we just stop running FIPS for these tests at all?

There is no proposal in this issue. The issue tracks the need to look into using INTEG_TEST distribution as much as we can and the proposal will come from that investigation. For the question you raise, I think we'd need to not set xpack.security.fips_mode.enabled when there are no xpack modules ( as setting it has no effect ). The security provider will still be in use and in fips mode.

I'm not sure what the argument is with "using FIPS mode", are you talking about the security provider? If so, I don't think we'll end up suggesting not using the security provider in FIPS mode.

@ywangd
Copy link
Member

ywangd commented Mar 5, 2021

Thanks for the clarification. My questions are not well formulated and they are based on my misunderstanding of the conversation in #66820. Please disregard them.

@jkakavas
Copy link
Member Author

jkakavas commented Mar 5, 2021

No worries Yang, thanks for asking. I think the issue description is not as clear as it should be and the questions are valid, I'll try and rewrite it an clean way

@jakelandis jakelandis self-assigned this Oct 24, 2022
jakelandis added a commit that referenced this issue Oct 26, 2022
This commit no longer explicitly sets the default configuration for FIPS tests.
This allows each project's tests to run in FIPS mode with out deviation (other
than the FIPS mode).

A side product of this change is that any REST test
can now enable security if they so choose without needing to use the default
distribution. This allows for additional usage of the integ_test distribution
which can help with testing modularization.

This only possible now that the security plugin is always included
with the integ_test distribution via #77632

fixes: #70005
related: #77632
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Security/FIPS Running ES in FIPS 140-2 mode Team:Security Meta label for security team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants