Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

native script custom explain feature removed in elasticsearch 1.4 #8561

Closed
ursvasan opened this issue Nov 19, 2014 · 7 comments
Closed

native script custom explain feature removed in elasticsearch 1.4 #8561

ursvasan opened this issue Nov 19, 2014 · 7 comments
Assignees
@brwe
Labels
:Search/Search Search-related issues that do not fall into other categories v1.4.3 v1.5.0 v2.0.0-beta1

Comments

@ursvasan
Copy link

I see that in issue #7245 , the interface ExplainableSearchScript and its use in ScriptScoreFunction is removed. I use that feature to customize (add all attributes in addition to query and parameters i use to compute the score in my script) the explain plan of my custom native script. It was fairly useful.

I am wondering why was it removed. Is there a different way to add my custom details to the explanation of script function ?
@brwe
Copy link
Contributor

brwe commented Nov 25, 2014

I was eager to remove code and apparently got a little overboard. I will make a pr shortly to add it again. I currently see now other way to add details from a search script to the explanation.

@brwe brwe self-assigned this Nov 25, 2014
brwe added a commit to brwe/elasticsearch that referenced this issue Nov 26, 2014
@brwe
scripts: add explainable script again
7bd859e 
explainable scripts were removed in elastic#7245 but they were used.
This commit adds them again.

closes elastic#8561
@brwe brwe mentioned this issue Nov 26, 2014
Closed
@brwe brwe added the v1.5.0 label Dec 16, 2014
brwe added a commit that referenced this issue Jan 19, 2015
@brwe
scripts: add explainable script again
f0d515b 
explainable scripts were removed in #7245 but they were used.
This commit adds them again.

closes #8561
@brwe brwe closed this as completed in 366ddfc Jan 19, 2015
@brwe brwe added v2.0.0-beta1 :Search/Search Search-related issues that do not fall into other categories labels Jan 19, 2015
@ghiron
Copy link
Contributor

ghiron commented Jan 19, 2015

@brwe : Could you add it back to v1.4 branch too please ?

brwe added a commit that referenced this issue Jan 19, 2015
@brwe
scripts: add explainable script again
5b031f6 
explainable scripts were removed in #7245 but they were used.
This commit adds them again.

closes #8561
@brwe
Copy link
Contributor

brwe commented Jan 19, 2015

@ghiron ok, pushed 5b031f6 to 1.4

@brwe brwe added the v1.4.3 label Jan 19, 2015
@ghiron
Copy link
Contributor

ghiron commented Jan 19, 2015

thank you @brwe !

@ursvasan
Copy link
Author

thanks for adding it back @brwe. LGTM

@maxjakob
Copy link

Since ExplainableSearchScript.explain now takes a float it is not possible any more to print the full tree of explanations.
@brwe Is there a plan to revert #7245 completely?

@brwe
Copy link
Contributor

brwe commented Feb 23, 2015

@maxjakob there is now: #9826
Can you check if that is what you need?

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@brwe
scripts: add explainable script again
a936be9 
explainable scripts were removed in elastic#7245 but they were used.
This commit adds them again.

closes elastic#8561
fixmebot bot referenced this issue in VectorXz/elasticsearch Apr 22, 2021
@VectorXz
Create TestFixMe.md
a9fae03
fixmebot bot referenced this issue in VectorXz/elasticsearch May 28, 2021
@VectorXz
Create Helloworld.md
1398a04
fixmebot bot referenced this issue in VectorXz/elasticsearch Aug 4, 2021
@VectorXz
Update Helloworld.md
f68abab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brwe brwe

Labels
:Search/Search Search-related issues that do not fall into other categories v1.4.3 v1.5.0 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add explainable script again brwe/elasticsearch
4 participants
@maxjakob @ghiron @brwe @ursvasan