-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Improve enrich policy execute 'wait_for_completion' docs #102291
[DOCS] Improve enrich policy execute 'wait_for_completion' docs #102291
Conversation
Documentation preview: |
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-data-management (Team:Data Management) |
Would anyone on the @elastic/es-data-management team have a moment to review this PR for correctness? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a few nitty suggestions.
docs/reference/ingest/apis/enrich/execute-enrich-policy.asciidoc
Outdated
Show resolved
Hide resolved
Co-authored-by: James Rodewig <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
💚 Backport successful
|
…tic#102291) * [DOCS] Improve enrich policy execute 'wait_for_completion' docs * Update docs/reference/ingest/apis/enrich/execute-enrich-policy.asciidoc Co-authored-by: James Rodewig <[email protected]> --------- Co-authored-by: James Rodewig <[email protected]>
) (#102664) * [DOCS] Improve enrich policy execute 'wait_for_completion' docs * Update docs/reference/ingest/apis/enrich/execute-enrich-policy.asciidoc --------- Co-authored-by: James Rodewig <[email protected]>
…tic#102291) * [DOCS] Improve enrich policy execute 'wait_for_completion' docs * Update docs/reference/ingest/apis/enrich/execute-enrich-policy.asciidoc Co-authored-by: James Rodewig <[email protected]> --------- Co-authored-by: James Rodewig <[email protected]>
We've had some feedback from users trying out enrich in ES|QL, that for large source indices, executing an enrich policy can take a long time and lead to timeouts.
One way to prevent timeouts is by setting
wait_for_completion
tofalse
. However, this is not obvious from the documentation. This PR tries to improve that by: 1) improving the description ofwait_for_completion
in the reference documentation for_execute
2) adding a paragraph about this setting in the reference documentation, and 3) changing all examples of_execute
to use?wait_for_completion=false
.