Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Improve enrich policy execute 'wait_for_completion' docs #102291

Conversation

abdonpijpelink
Copy link
Contributor

We've had some feedback from users trying out enrich in ES|QL, that for large source indices, executing an enrich policy can take a long time and lead to timeouts.

One way to prevent timeouts is by setting wait_for_completion to false. However, this is not obvious from the documentation. This PR tries to improve that by: 1) improving the description of wait_for_completion in the reference documentation for _execute 2) adding a paragraph about this setting in the reference documentation, and 3) changing all examples of _execute to use ?wait_for_completion=false.

@abdonpijpelink abdonpijpelink added >docs General docs changes :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP auto-backport-and-merge v8.11.2 labels Nov 16, 2023
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added v8.12.0 Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team labels Nov 16, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@abdonpijpelink
Copy link
Contributor Author

Would anyone on the @elastic/es-data-management team have a moment to review this PR for correctness?

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a few nitty suggestions.

Copy link
Member

@jbaiera jbaiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abdonpijpelink abdonpijpelink merged commit ac973f0 into elastic:main Nov 27, 2023
@abdonpijpelink abdonpijpelink deleted the docs-enrich-policy-execute-wait-for-completion branch November 27, 2023 16:17
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.11

abdonpijpelink added a commit to abdonpijpelink/elasticsearch that referenced this pull request Nov 27, 2023
…tic#102291)

* [DOCS] Improve enrich policy execute 'wait_for_completion' docs

* Update docs/reference/ingest/apis/enrich/execute-enrich-policy.asciidoc

Co-authored-by: James Rodewig <[email protected]>

---------

Co-authored-by: James Rodewig <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Nov 27, 2023
) (#102664)

* [DOCS] Improve enrich policy execute 'wait_for_completion' docs

* Update docs/reference/ingest/apis/enrich/execute-enrich-policy.asciidoc



---------

Co-authored-by: James Rodewig <[email protected]>
timgrein pushed a commit to timgrein/elasticsearch that referenced this pull request Nov 30, 2023
…tic#102291)

* [DOCS] Improve enrich policy execute 'wait_for_completion' docs

* Update docs/reference/ingest/apis/enrich/execute-enrich-policy.asciidoc

Co-authored-by: James Rodewig <[email protected]>

---------

Co-authored-by: James Rodewig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v8.11.2 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants