Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.11] Fix InternalEngineTests.testMergeThreadLogging (#102640) #102649

Merged
merged 1 commit into from
Nov 27, 2023
Merged

[8.11] Fix InternalEngineTests.testMergeThreadLogging (#102640) #102649

merged 1 commit into from
Nov 27, 2023
+34 −19

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Nov 27, 2023

Backports the following commits to 8.11:

@tlrx
Fix InternalEngineTests.testMergeThreadLogging (elastic#102640)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
3466ce8 
The test has to wait for all merge thread log messages (include Lucene ones) 
to be seen before reset the log level and stop the appender.

Previous attempt wasn't enough: the test failure in elastic#90071 (comment) shows 
that Lucene's merge scheduler thread can log after the Elasticsearch one, and 
if the appender has been closed in the meanwhile it can fail the test.

This change ensure that the appender saw the Merge Scheduler end message 
before resetting the log level and close the engine.

Closes elastic#90071
@tlrx tlrx added :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels Nov 27, 2023
@elasticsearchmachine elasticsearchmachine mentioned this pull request Nov 27, 2023
Merged
@elasticsearchmachine elasticsearchmachine merged commit 7f23419 into elastic:8.11 Nov 27, 2023
@tlrx tlrx deleted the backport/8.11/pr-102640 branch November 27, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v8.11.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tlrx @elasticsearchmachine