Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Deprecate machine learning on Intel macOS #104087

Merged
merged 3 commits into from
Jan 16, 2024
Merged

[ML] Deprecate machine learning on Intel macOS #104087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bbd764
[ML] Deprecate Intel macOS for ML
droberts195 Jan 8, 2024
52497e1
Update docs/changelog/104087.yaml
droberts195 Jan 8, 2024
322b178
Complete changelog
droberts195 Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions docs/changelog/104087.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
pr: 104087
summary: Deprecate machine learning on Intel macOS
area: Machine Learning
type: deprecation
issues: []
deprecation:
title: Deprecate machine learning on Intel macOS
area: Packaging
details: The machine learning plugin will be permanently disabled on macOS x86_64
in new minor versions released from December 2024 onwards.
impact: To continue to use machine learning functionality on macOS please switch to
an arm64 machine (Apple silicon). Alternatively, it will still be possible to run
Elasticsearch with machine learning enabled in a Docker container on macOS x86_64.
13 changes: 13 additions & 0 deletions x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MachineLearning.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
import org.elasticsearch.cluster.service.ClusterService;
import org.elasticsearch.common.breaker.CircuitBreaker;
import org.elasticsearch.common.io.stream.NamedWriteableRegistry;
import org.elasticsearch.common.logging.DeprecationCategory;
import org.elasticsearch.common.logging.DeprecationLogger;
import org.elasticsearch.common.settings.ClusterSettings;
import org.elasticsearch.common.settings.IndexScopedSettings;
import org.elasticsearch.common.settings.Setting;
Expand Down Expand Up @@ -68,6 +70,7 @@
import org.elasticsearch.plugins.IngestPlugin;
import org.elasticsearch.plugins.MapperPlugin;
import org.elasticsearch.plugins.PersistentTaskPlugin;
import org.elasticsearch.plugins.Platforms;
import org.elasticsearch.plugins.Plugin;
import org.elasticsearch.plugins.SearchPlugin;
import org.elasticsearch.plugins.ShutdownAwarePlugin;
Expand Down Expand Up @@ -753,6 +756,7 @@ public void loadExtensions(ExtensionLoader loader) {
public static final int MAX_LOW_PRIORITY_MODELS_PER_NODE = 100;

private static final Logger logger = LogManager.getLogger(MachineLearning.class);
private static final DeprecationLogger deprecationLogger = DeprecationLogger.getLogger(MachineLearning.class);

private final Settings settings;
private final boolean enabled;
Expand Down Expand Up @@ -919,6 +923,15 @@ public Collection<?> createComponents(PluginServices services) {
return List.of(new JobManagerHolder(), new MachineLearningExtensionHolder());
}

if ("darwin-x86_64".equals(Platforms.PLATFORM_NAME)) {
String msg = "The machine learning plugin will be permanently disabled on macOS x86_64 in new minor versions released "
+ "from December 2024 onwards. To continue to use machine learning functionality on macOS please switch to an arm64 "
+ "machine (Apple silicon). Alternatively, it will still be possible to run Elasticsearch with machine learning "
+ "enabled in a Docker container on macOS x86_64.";
logger.warn(msg);
deprecationLogger.warn(DeprecationCategory.PLUGINS, "ml-darwin-x86_64", msg);
}

machineLearningExtension.get().configure(environment.settings());

this.mlUpgradeModeActionFilter.set(new MlUpgradeModeActionFilter(clusterService));
Expand Down