Fix gradle run on Serverless

[tvernum]

On Serverless it is not possible to configure deprecation indexing (it is always off). This commit updates the behaviour of ElasticsearchCluster to no longer attempt to configure deprecation indexing on stateless nodes.

[elasticsearchmachine]

Pinging @elastic/es-delivery (Team:Delivery)

[tvernum]

I'll admit that this is a bit of a hack, and I'm open to other suggestions.
The constraints that I ran into are:

• elasticsearch.serverless-run.gradle.kts configures a test cluster directly (not a spec) so it can't use a settings provider (which is how we solved this elsewhere)
• ElasticsearchNode does not expose which modules exist, so I cannot make this dependent on the deprecation module existing
• Serverless doesn't appear to be an exposed concept (as a distribution type, or version number, etc) in ElasticsearchNode (which is generally a good thing, but left me with very few options here).

This change allows ./gradlew run to work in serverless again, which is a good thing, and I would like to make that happen. I am, however, very happy to iterate on this in order to come up with a cleaner solution if people don't like this one.

[mark-vieira]

This is fine by me. I think the long term solution here is to have gradlew run use the new test clusters infrastructure rather than ElasticsearchNode since it's considerably more extensible.

[breskeby]

You just made this change on the old test cluster framework that is kind of deprecated and will hopefully dissapear one day. Can you also apply that on our new junit rule based implementation too. (see

elasticsearch/test/test-clusters/src/main/java/org/elasticsearch/test/cluster/local/DefaultSettingsProvider.java

Line 35 in 6ace408

settings.put("cluster.deprecation_indexing.enabled", "false");

)

[pgomulka]

I am not sure this will work.
the cluster.deprecation_indexing.enabled should not be known. The deprecation indexing is part of :xpack:deprecation module which is excluded in serverless

we will be getting unknown settings exception if we set the cluster.deprecation_indexing.enabled =false

see the change that removed the module https://github.com/elastic/elasticsearch-serverless/pull/1460

[pgomulka]

ok I see it now :)
this check will PREVENT the use of that setting.
looks great to me.

[pgomulka]

You just made this change on the old test cluster framework that is kind of deprecated and will hopefully dissapear one day. Can you also apply that on our new junit rule based implementation too. (see

[elasticsearch/test/test-clusters/src/main/java/org/elasticsearch/test/cluster/local/DefaultSettingsProvider.java](https://github.com/elastic/elasticsearch/blob/6ace40823966a41f11ac89eb3ce566636ab699a9/test/test-clusters/src/main/java/org/elasticsearch/test/cluster/local/DefaultSettingsProvider.java#L35)

Line 35 in [6ace408](https://github.com/elastic/elasticsearch/commit/6ace40823966a41f11ac89eb3ce566636ab699a9)

 settings.put("cluster.deprecation_indexing.enabled", "false"); 
)

@breskeby
we don't use this in serverless, so perhaps it is safe.

[pgomulka]

I confirmed with @breskeby it is safe to merge.