Introduce TimeSeriesRoutingIdFieldMapper and use it to create TSDB ids #106080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # server/src/test/java/org/elasticsearch/index/mapper/RootObjectMapperTests.java
# Conflicts: # modules/data-streams/src/yamlRestTest/resources/rest-api-spec/test/data_stream/150_tsdb.yml
|
@elasticsearchmachine run elasticsearch-ci/bwc-snapshots |
|
I think the engine level changes in this PR can be undone and use routing based on index mode in the mapping / document parser: martijnvg@609405c The tests in server and data stream module passed with this change. |
This reverts commit e916599
martijnvg
reviewed
Mar 13, 2024
modules/reindex/src/yamlRestTest/resources/rest-api-spec/test/update_by_query/90_tsdb.yml
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/routing/IndexRouting.java
Outdated
Show resolved
Hide resolved
...les/lang-painless/src/main/java/org/elasticsearch/painless/action/PainlessExecuteAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/routing/IndexRouting.java
Outdated
Show resolved
Hide resolved
|
@elasticsearchmachine run elasticsearch-ci/part-1 |
martijnvg
approved these changes
Mar 13, 2024
...les/lang-painless/src/main/java/org/elasticsearch/painless/action/PainlessExecuteAction.java
Outdated
Show resolved
Hide resolved
|
Thanks for the patience and the thorough review! |
kkrik-es
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting non-keyword fields requires updating non-keyword fields in the routing path to be included in routing calculations. Routing is performed in coordinating nodes that lack mappings (or mappings haven't been created yet, for dynamically-defined dimensions), so the routing hash they calculate are passed to data nodes and stored in a new fields, namely _ts_routind_hash. This is included in the _id field, in turn, so that it can consistently reach the right shard for get-by-id and delete-by-id operations.
A few interesting points:
routingfield inIndexRequest; adding another field to the latter requires updating dozens of classes.idprefix.Related to #103567