Tests: Add shortcut "all" to skip version ranges in rest tests #10702
+23
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@karmi I think this is what you wanted? |
|
@rjernst Yes, thanks, I think this better communicates the intent! |
|
LGTM thanks for doing this @rjernst |
|
LGTM too |
This was suggested on elastic#10656 as cleaner than " - " to indicate all versions should be skipped. closes elastic#10702
rjernst
force-pushed
the
fix/rest-skip-all
branch
from
d91fd35 to
2d54738
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was suggested on #10656 as cleaner than " - " to indicate all
versions should be skipped.