Cluster state role mapper file settings service #107886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @albertzaharovits, I've created a changelog YAML for you. |
|
Pinging @elastic/es-security (Team:Security) |
rjernst
approved these changes
Apr 25, 2024
…er-file-settings-service
|
@elasticsearchmachine run elasticsearch-ci/part-4-fips |
|
@elasticsearchmachine test elasticsearch-ci/part-4-fips |
|
@elasticsearchmachine run elasticsearch-ci/part-4 |
|
@elasticsearchmachine test elasticsearch-ci/part-4 |
|
@elasticsearchmachine test this please |
albertzaharovits
deleted the
cluster-state-role-mapper-file-settings-service
branch
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 7, 2024
…)" This reverts commit 391136c.
|
Reverting this, hopefully temporarily, in #108346. It's not that this change is bad, but it's exposing a bug in the file-based settings service that we need to fix first. |
DaveCTurner
added a commit
that referenced
this pull request
May 7, 2024
albertzaharovits
added a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
May 13, 2024
…tic#107886)" (elastic#108346)" This reverts commit 26db243.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Currently, this PR includes the changes from #107410 (which introduces the
ClusterStateRoleMapper). This is simpler to review after #107410 is merged in.This PR simplifies the
ReservedRoleMappingActionimplementation, which is part of theFileSettingsServiceinfrastructure, such that it stores the role mappings it parses from thesettings.jsonfile into the cluster state custom metadata that's used by the newClusterStateRoleMapper. The native role mappings (stored in the .security index)are left untouched by the
ReservedRoleMappingAction.