Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESQL: Entirely drop version field #109169

Merged
merged 2 commits into from
May 29, 2024
Merged

ESQL: Entirely drop version field #109169

merged 2 commits into from
May 29, 2024

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented May 29, 2024

This field is no longer supported.

@nik9000
ESQL: Entirely drop version field
1a742b3 
This field is no longer supported.
@nik9000 nik9000 requested a review from alex-spies May 29, 2024 15:01
@elasticsearchmachine elasticsearchmachine added v8.14.1 Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels May 29, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@nik9000
Copy link
Member Author

nik9000 commented May 29, 2024

Note that this is targeting 8.14 and not main. We'll forward port this once serverless is ready.

alex-spies
alex-spies approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Nik!

I think we can also remove the respective tests in EsqlQueryRequestTests:

  • testAnyVersionIsValid
  • testMissingVersionIsValid

x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/esql/10_basic.yml
esql.query:
body:
query: 'from test'
version: cat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to say that we could also just use the EsqlQueryRequestTests, but this is better.

@nik9000
Copy link
Member Author

nik9000 commented May 29, 2024

I think we can also remove the respective tests in EsqlQueryRequestTests:

👍

@nik9000 nik9000 merged commit 652066d into elastic:8.14 May 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-spies alex-spies alex-spies approved these changes

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL blocker >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.14.0 v8.14.1 v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nik9000 @elasticsearchmachine @alex-spies