Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable xpack yaml tests #112031

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

kkrik-es
Copy link
Contributor

This was auto-silenced as part of #111944, although a single test was failing.

Related to #111944.

@kkrik-es kkrik-es self-assigned this Aug 20, 2024
@kkrik-es kkrik-es added >test-mute Use for PR that only mute tests and removed v8.16.0 labels Aug 20, 2024
@kkrik-es kkrik-es requested a review from dnhatn August 20, 2024 16:11
@kkrik-es kkrik-es added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Aug 20, 2024
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dnhatn
Copy link
Member

dnhatn commented Aug 20, 2024

Should we mute Test Status instead?

@kkrik-es
Copy link
Contributor Author

Should we mute Test Status instead?

Hm there's apparently more per slack thread.. Could be due to a draft PR tho.

@kkrik-es kkrik-es marked this pull request as ready for review August 20, 2024 16:20
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Aug 20, 2024
@kkrik-es kkrik-es added Team:StorageEngine :StorageEngine/Mapping The storage related side of mappings v8.16.0 labels Aug 20, 2024
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Aug 20, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Contributor

@lkts lkts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scary.

@kkrik-es
Copy link
Contributor Author

Test failures are unrelated.

@kkrik-es kkrik-es merged commit a294265 into elastic:main Aug 21, 2024
12 of 15 checks passed
@kkrik-es kkrik-es deleted the synthetic-source/transform-test branch August 21, 2024 06:34
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this pull request Sep 4, 2024
davidkyle pushed a commit to davidkyle/elasticsearch that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :StorageEngine/Mapping The storage related side of mappings Team:StorageEngine >test-mute Use for PR that only mute tests v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants