Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logs-apm.error-*: define log.level field as keyword #112440

Merged
merged 3 commits into from
Sep 3, 2024
Merged

logs-apm.error-*: define log.level field as keyword #112440

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
441541f
apm: Set log.level: error on all apm error logs
marclop Sep 3, 2024
6ac034d
Update docs/changelog/112440.yaml
marclop Sep 3, 2024
9644710
map log.level as keyword
marclop Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/112440.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 112440
summary: "Apm: Set log.level: error on all apm error logs"
area: Data streams
type: bug
issues: []
3 changes: 3 additions & 0 deletions x-pack/plugin/apm-data/src/main/resources/index-templates/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ template:
processor.event:
type: constant_keyword
value: error
log.level:
type: constant_keyword
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about using constant_keyword for this. I think OTel exception logs could explicitly set a log level to something other than "error", which could conflict with this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh... I wasn't aware of that case. Should it then be mapped in apm-data and just added as a keyword?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced we should set a default value for log.level, so wouldn't make a change to apm-data; but it makes sense to map the field as keyword.

value: error
settings:
index:
default_pipeline: logs-apm.error@default-pipeline
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugin/apm-data/src/main/resources/resources.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# "version" holds the version of the templates and ingest pipelines installed
# by xpack-plugin apm-data. This must be increased whenever an existing template or
# pipeline is changed, in order for it to be updated on Elasticsearch upgrade.
version: 8
version: 9

component-templates:
# Data lifecycle.
Expand Down
26 changes: 26 additions & 0 deletions x-pack/plugin/apm-data/src/yamlRestTest/resources/rest-api-spec/test/20_error_logs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
---
setup:
- do:
cluster.health:
wait_for_events: languid

---
"Test logs-apm.error-* error log fields":
- do:
bulk:
index: logs-apm.error-log-level-testing
refresh: true
body:
# Non-empty error.exception.message used
- create: {}
- '{"@timestamp": "2017-06-22", "error": {"log": {"message": "loglevel"}, "exception": [{"message": "exception_used"}]}}'

- is_false: errors

- do:
search:
index: logs-apm.error-log-level-testing
body:
fields: ["log.level"]
- length: { hits.hits: 1 }
- match: { hits.hits.0.fields: {"log.level": ["error"]} }