Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analyzed wildcard query in simple_query_string when disjunctions is empty #114264

Merged

Conversation

halilbulentorhon
Copy link
Contributor

@halilbulentorhon halilbulentorhon commented Oct 7, 2024

This change fixes analyzed wildcard query in simple_query_string when disjunctions is empty.

Closes #114185

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.0.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Oct 7, 2024
@halilbulentorhon halilbulentorhon changed the title Fix analyzed wildcard query in simple_query_string Fix analyzed wildcard query in simple_query_string when disjunctions is empty Oct 7, 2024
@benwtrent benwtrent self-assigned this Oct 8, 2024
@benwtrent benwtrent added v8.16.0 :Search Relevance/Search Catch all for Search Relevance >bug labels Oct 8, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Oct 8, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Oct 8, 2024
Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frustrating that we didn't fix this back when we fixed query_string!

The fix looks good!

@benwtrent
Copy link
Member

buildkite test this please

@benwtrent
Copy link
Member

@elasticmachine update branch

@benwtrent
Copy link
Member

buildkite test this please

@benwtrent benwtrent merged commit 6955bc1 into elastic:main Oct 8, 2024
18 checks passed
@benwtrent
Copy link
Member

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

benwtrent pushed a commit to benwtrent/elasticsearch that referenced this pull request Oct 8, 2024
…is empty (elastic#114264)

This change fixes analyzed wildcard query in simple_query_string when disjunctions is empty.

Closes elastic#114185

(cherry picked from commit 6955bc1)
@benwtrent
Copy link
Member

💚 All backports created successfully

Status Branch Result
8.15

Questions ?

Please refer to the Backport tool documentation

benwtrent pushed a commit to benwtrent/elasticsearch that referenced this pull request Oct 8, 2024
…is empty (elastic#114264)

This change fixes analyzed wildcard query in simple_query_string when disjunctions is empty.

Closes elastic#114185

(cherry picked from commit 6955bc1)
@benwtrent
Copy link
Member

🎉 🎉 🎉 @halilbulentorhon merged and I will backport 🎉 🎉 🎉

@halilbulentorhon
Copy link
Contributor Author

@benwtrent thanks a lot for your quick review and quick responses!

elasticsearchmachine pushed a commit that referenced this pull request Oct 8, 2024
…is empty (#114264) (#114355)

This change fixes analyzed wildcard query in simple_query_string when disjunctions is empty.

Closes #114185

(cherry picked from commit 6955bc1)

Co-authored-by: Halil Bülent Orhon <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Oct 9, 2024
…is empty (#114264) (#114354)

This change fixes analyzed wildcard query in simple_query_string when disjunctions is empty.

Closes #114185

(cherry picked from commit 6955bc1)

Co-authored-by: Halil Bülent Orhon <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
matthewabbott pushed a commit to matthewabbott/elasticsearch that referenced this pull request Oct 10, 2024
…is empty (elastic#114264)

This change fixes analyzed wildcard query in simple_query_string when disjunctions is empty.

Closes elastic#114185
davidkyle pushed a commit to davidkyle/elasticsearch that referenced this pull request Oct 13, 2024
…is empty (elastic#114264)

This change fixes analyzed wildcard query in simple_query_string when disjunctions is empty.

Closes elastic#114185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug external-contributor Pull request authored by a developer outside the Elasticsearch team :Search Relevance/Search Catch all for Search Relevance Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v8.15.3 v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wildcard Query with Stop Words in Romanian Analyzer Generates MatchNoDocsQuery
4 participants