Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.15] Default enable cluster state role mapper (#114337) #114421

Merged
merged 8 commits into from
Oct 9, 2024

Conversation

n1v0lg
Copy link
Contributor

@n1v0lg n1v0lg commented Oct 9, 2024

Backports #114337 with following commits:

This PR default-enables cluster-state role mappings as the first part of the mitigation for a regression in ECK introduced by #107410. 

Prior to this PR, cluster-state role mappings were written to cluster-state, but not read from it. 

With this PR, cluster-state role mappings will be read and used to assign roles to users, i.e. in user role resolution. 

However, they will not be included in the output of the [Get role mappings API](https://www.elastic.co/guide/en/elasticsearch/reference/current/security-api-get-role-mapping.html) yet. Exposing them via API is a target for a follow-up fix.

Relates: ES-9628
Supersedes: #113900
@n1v0lg n1v0lg added >bug :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v8.15.3 labels Oct 9, 2024
@n1v0lg n1v0lg self-assigned this Oct 9, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @n1v0lg, I've created a changelog YAML for you.

@n1v0lg n1v0lg removed the v8.15.4 label Oct 9, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @n1v0lg, I've created a changelog YAML for you.

@n1v0lg n1v0lg added backport Team:Security Meta label for security team labels Oct 9, 2024
@n1v0lg n1v0lg marked this pull request as ready for review October 9, 2024 15:14
@n1v0lg n1v0lg added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Oct 9, 2024
@jakelandis
Copy link
Contributor

all CI checks passed but elasticsearch-ci/packaging-tests-windows-sample which is hanging on this message:

Build Finished Action: Collecting archive files...
Uploading buildkite artifact: 35389.tar.bz2...

That is a known issue and being addressed and all the tests passed. merging this PR.

@jakelandis jakelandis merged commit 26fcc89 into 8.15 Oct 9, 2024
19 of 21 checks passed
@jakelandis jakelandis deleted the backport-114337 branch October 9, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >bug :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team v8.15.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants