Enable _tier based coordinator rewrites for all indices (not just mounted indices) #115797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine update branch |
|
@elasticmachine update branch |
1 similar comment
|
@elasticmachine update branch |
|
@elasticmachine update branch |
andreidan
changed the title
|
Hi @andreidan, I've created a changelog YAML for you. |
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
elasticsearchmachine
added
the
Team:Search Foundations
|
@elasticmachine update branch |
|
There are no new commits on the base branch. |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
|
restarting test due to #116003 |
|
@elasticmachine run elasticsearch-ci/part-3 |
|
@elasticmachine update branch |
|
There are no new commits on the base branch. |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
andreidan
added
auto-merge-without-approval
💔 Backport failed
You can use sqren/backport to manually backport by running |
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Nov 1, 2024
…nted indices) (elastic#115797) As part of elastic#114990 we enabled using the `_tier` field as part of the coordinator rewrite in order to skip shards that do not match a `_tier` filter, but only for fully/partially mounted indices. This PR enhances the previous work by allowing a coordinator rewrite to skip shards that will not match the `_tier` query for all indices (irrespective of their lifecycle state i.e. hot and warm indices can now skip shards based on the `_tier` query) Note however, that hot/warm indices will not automatically take advantage of the `can_match` coordinator rewrite (like read only indices do) but only the search requests that surpass the `pre_filter_shard_size` threshold will. Relates to [elastic#114910](elastic#114910) (cherry picked from commit 71dfb06) Signed-off-by: Andrei Dan <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 1, 2024
…st mounted indices) (#115797) (#116076) * Enable _tier based coordinator rewrites for all indices (not just mounted indices) (#115797) As part of #114990 we enabled using the `_tier` field as part of the coordinator rewrite in order to skip shards that do not match a `_tier` filter, but only for fully/partially mounted indices. This PR enhances the previous work by allowing a coordinator rewrite to skip shards that will not match the `_tier` query for all indices (irrespective of their lifecycle state i.e. hot and warm indices can now skip shards based on the `_tier` query) Note however, that hot/warm indices will not automatically take advantage of the `can_match` coordinator rewrite (like read only indices do) but only the search requests that surpass the `pre_filter_shard_size` threshold will. Relates to [#114910](#114910) (cherry picked from commit 71dfb06) Signed-off-by: Andrei Dan <[email protected]> * Fix test compilation --------- Co-authored-by: Elastic Machine <[email protected]>
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
…nted indices) (elastic#115797) As part of elastic#114990 we enabled using the `_tier` field as part of the coordinator rewrite in order to skip shards that do not match a `_tier` filter, but only for fully/partially mounted indices. This PR enhances the previous work by allowing a coordinator rewrite to skip shards that will not match the `_tier` query for all indices (irrespective of their lifecycle state i.e. hot and warm indices can now skip shards based on the `_tier` query) Note however, that hot/warm indices will not automatically take advantage of the `can_match` coordinator rewrite (like read only indices do) but only the search requests that surpass the `pre_filter_shard_size` threshold will. Relates to [elastic#114910](elastic#114910)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #114990 we enabled using the
_tierfield as part of the coordinator rewrite in order to skip
shards that do not match a
_tierfilter, but only forfully/partially mounted indices.
This PR enhances the previous work by allowing a coordinator
rewrite to skip shards that will not match the
_tierquery forall indices (irrespective of their lifecycle state i.e. hot and warm
indices can now skip shards based on the
_tierquery)Note however, that hot/warm indices will not automatically
take advantage of the
can_matchcoordinator rewrite(like read only indices do) but only the search requests that
surpass the
pre_filter_shard_sizethreshold will.Relates to #114910