Improve handling of nested fields in index reader wrappers #118757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update enhances the handling of parent filters to ensure proper exclusion of child documents.
jimczi
added
>enhancement
:Security/Authorization
|
Pinging @elastic/es-security (Team:Security) |
|
Hi @jimczi, I've created a changelog YAML for you. |
martijnvg
approved these changes
Dec 18, 2024
| if (NestedHelper.mightMatchNestedDocs(roleQuery, context)) { | ||
| roleQuery = new BooleanQuery.Builder().add(roleQuery, FILTER) | ||
| .add(Queries.newNonNestedFilter(context.indexVersionCreated()), FILTER) | ||
| .build(); | ||
| } | ||
| filter.add(roleQuery, SHOULD); |
There was a problem hiding this comment.
I see, the fix here is that roleQuery was updated, but not in the filter bool query. This ensures that roleQuery is added when we determined nested docs can match.
jimczi
added
v8.16.3
auto-backport
💔 Backport failed
You can use sqren/backport to manually backport by running |
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Dec 18, 2024
…18757) This update enhances the handling of parent filters to ensure proper exclusion of child documents.
jimczi
removed
the
auto-backport
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Dec 18, 2024
…18757) This update enhances the handling of parent filters to ensure proper exclusion of child documents.
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Dec 18, 2024
…18757) This update enhances the handling of parent filters to ensure proper exclusion of child documents.
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Dec 18, 2024
…18757) This update enhances the handling of parent filters to ensure proper exclusion of child documents.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 18, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 18, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 18, 2024
navarone-feekery
pushed a commit
to navarone-feekery/elasticsearch
that referenced
this pull request
Dec 26, 2024
…18757) This update enhances the handling of parent filters to ensure proper exclusion of child documents.
sarog
pushed a commit
to sarog/elasticsearch
that referenced
this pull request
Jan 22, 2025
…18757) (elastic#118977) This update enhances the handling of parent filters to ensure proper exclusion of child documents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update enhances the handling of parent filters to ensure proper exclusion of child documents.