Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how reindex data stream index action handles api blocks #120084

Conversation

parkertimmins
Copy link
Contributor

  • fail quickly if index has read or metadata block
  • add write block, but also allow read-only or read-only-allow-delete
  • filter write, read-only, and read-only-allow-delete from dest index

- fail quickly if index has read or metadata block
- add write block, but also allow read-only, read-only-allow-delete
- filter write, read-only, and read-only-allow-delete from dest index
@parkertimmins parkertimmins added >enhancement :Data Management/Data streams Data streams and their lifecycles auto-backport Automatically create backport pull requests when merged v8.18.0 labels Jan 13, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @parkertimmins, I've created a changelog YAML for you.

@parkertimmins parkertimmins marked this pull request as ready for review January 14, 2025 15:00
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Jan 14, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Contributor

@lukewhiting lukewhiting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@parkertimmins parkertimmins merged commit cd82da5 into elastic:main Jan 14, 2025
16 checks passed
@parkertimmins parkertimmins deleted the reindex-datastream-filter-read-only-block branch January 14, 2025 16:11
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

parkertimmins added a commit to parkertimmins/elasticsearch that referenced this pull request Jan 14, 2025
…tic#120084)

- fail quickly if index has read or metadata block
- add write block, but proceed if already has read-only or read-only-allow-delete
- filter write, read-only, and read-only-allow-delete from dest index
- results in dest index having no blocks
elasticsearchmachine pushed a commit that referenced this pull request Jan 14, 2025
) (#120132)

- fail quickly if index has read or metadata block
- add write block, but proceed if already has read-only or read-only-allow-delete
- filter write, read-only, and read-only-allow-delete from dest index
- results in dest index having no blocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Data Management/Data streams Data streams and their lifecycles >enhancement Team:Data Management Meta label for data/management team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants