Source filtering: only accept array items if the previous include pattern matches #22593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tern matches Source filtering was always accepting array items even if the include pattern did not match. Closes elastic#22557
mikemccand
added
:Core/Infra/Core
nik9000
approved these changes
Jan 12, 2017
| assertThat((Integer) ((List) falteredMap.get("array")).get(0), equalTo(1)); | ||
| assertThat(((Map<String, Object>) ((List) falteredMap.get("array")).get(1)).size(), equalTo(1)); | ||
| assertThat((Integer) ((Map<String, Object>) ((List) falteredMap.get("array")).get(1)).get("nested"), equalTo(2)); | ||
| assertThat(((List) filteredMap.get("array")).size(), equalTo(1)); |
There was a problem hiding this comment.
assertThat((List) filteredMap.get("array"), hasSize(1)) has better error messages.
There was a problem hiding this comment.
But you are just fixing a typo so you can skip it.
There was a problem hiding this comment.
Oh thank you for that pointer; I didn't know about hasSize ... I'll change it
|
OK I switched to |
Oh! |
nik9000
approved these changes
Jan 12, 2017
javanna
added a commit
that referenced
this pull request
May 13, 2020
When using source filtering exclusions, empty arrays are not preserved in documents, and no empty arrays are returned if arrays are empty after applying exclusions. We have special treatment to make sure that we preserve empty objects, but the behaviour for arrays is different. It looks like this regression was introduced by #22593, shortly after we refactored source filtering to use automata (#20736). Note that this change affects what the search API returns when using source exclusions, as well as what gets indexed when using source exclusions for the _source field. Closes #23796
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
May 13, 2020
When using source filtering exclusions, empty arrays are not preserved in documents, and no empty arrays are returned if arrays are empty after applying exclusions. We have special treatment to make sure that we preserve empty objects, but the behaviour for arrays is different. It looks like this regression was introduced by elastic#22593, shortly after we refactored source filtering to use automata (elastic#20736). Note that this change affects what the search API returns when using source exclusions, as well as what gets indexed when using source exclusions for the _source field. Closes elastic#23796
javanna
added a commit
that referenced
this pull request
May 13, 2020
When using source filtering exclusions, empty arrays are not preserved in documents, and no empty arrays are returned if arrays are empty after applying exclusions. We have special treatment to make sure that we preserve empty objects, but the behaviour for arrays is different. It looks like this regression was introduced by #22593, shortly after we refactored source filtering to use automata (#20736). Note that this change affects what the search API returns when using source exclusions, as well as what gets indexed when using source exclusions for the _source field. Closes #23796
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source filtering was incorrectly always accepting array items even if the include pattern did not match.
Closes #22557