Upgrade checkstyle to version 7.5 #22960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit upgrades the checkstyle configuration from version 5.9 to version 7.5, the latest version as of today. The main enhancement obtained via this upgrade is better detection of redundant modifiers.
nik9000
approved these changes
Feb 3, 2017
tlrx
approved these changes
Feb 3, 2017
There was a problem hiding this comment.
I skimmed over the changes and it LGTM.
For the record I copy a comment from @nik9000 that summarizes the changes:
publicmethods on non-publicclasses don't make sense. Remove the modifier and let the method inherit the modifier.- try-with-resources variables should not be declared
finalbecause they are implicitlyfinal.finaladds no extra information for the reader. I guess that makes them names rather than variables.... enums are alwaystaticso there is no need to declare themstatic.finaldoesn't do anything on anonymous classes because they can't be extended anyway. So we just remove the modifier.- Classes declared inside of interfaces are always
staticso we shouldn't also declare them asstatic.
I'm not sure that IDEs report all the violations but I'm personally fine with that, thanks @jasontedor
jasontedor
added a commit
that referenced
this pull request
Feb 3, 2017
This commit upgrades the checkstyle configuration from version 5.9 to version 7.5, the latest version as of today. The main enhancement obtained via this upgrade is better detection of redundant modifiers. Relates #22960
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit upgrades the checkstyle configuration from version 5.9 to
version 7.5, the latest version as of today. The main enhancement
obtained via this upgrade is better detection of redundant modifiers.