Detect using logging before configuration #24076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can easily happen that we touch a logger before logging is configured due to chains of static intializers and other such scenarios. This commit adds detection for this mechanism that will fail startup if we touch a logger before logging is configured. This is a bug that will cause builds to fail.
jasontedor
added
:Core/Infra/Logging
nik9000
approved these changes
Apr 12, 2017
|
|
||
| public class LogConfigurator { | ||
|
|
||
| private static final AtomicBoolean error = new AtomicBoolean(); | ||
|
|
||
| private static final StatusListener LISTENER = new StatusConsoleListener(Level.ERROR) { |
There was a problem hiding this comment.
Maybe name it UNCONFIGURED_LOG_CATCHER or something.
|
|
||
| public class LogConfigurator { | ||
|
|
||
| private static final AtomicBoolean error = new AtomicBoolean(); |
There was a problem hiding this comment.
The most likely error that is logged here is that we touched a logger before it's configured, but any error message from the status logger is going to trip this check so I'd rather keep the name general. I'm happy to add a comment that explains this though.
| private static void checkErrorListener() { | ||
| assert errorListenerIsRegistered() : "expected error listener to be registered"; | ||
| if (error.get()) { | ||
| throw new IllegalStateException("status logger logged an error before logging was configured"); |
There was a problem hiding this comment.
Maybe change the message to something like "used logging before it was configured"?
|
Makes sense to me!
…On Wed, Apr 12, 2017, 9:02 PM Jason Tedor ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
core/src/main/java/org/elasticsearch/common/logging/LogConfigurator.java
<#24076 (comment)>
:
>
public class LogConfigurator {
+ private static final AtomicBoolean error = new AtomicBoolean();
The most likely error that is logged here is that we touched a logger
before it's configured, but any error message from the status logger is
going to trip this check so I'd rather keep the name general. I'm happy to
add a comment that explains this though.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#24076 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANLohoFiG33UibC9nu0JhLf5h9gkYLxks5rvXQJgaJpZM4M78km>
.
|
jasontedor
added a commit
that referenced
this pull request
Apr 13, 2017
It can easily happen that we touch a logger before logging is configured due to chains of static intializers and other such scenarios. This commit adds detection for this mechanism that will fail startup if we touch a logger before logging is configured. This is a bug that will cause builds to fail. Relates #24076
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can easily happen that we touch a logger before logging is configured due to chains of static intializers and other such scenarios. This commit adds detection for this mechanism that will fail startup if we touch a logger before logging is configured. This is a bug that will cause builds to fail.