Fix legacy GeoPointField decoding in FieldStats #24534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nknize
added
:Data Management/Indices APIs
|
Can you add a test? |
|
@nknize if adding a test is not possible you can also remove the field stats impl for legacy point ? This is not needed and we don't want to fail a request for an encoding problem. |
jimczi
approved these changes
May 11, 2017
| @@ -676,6 +687,27 @@ public static FieldStats randomFieldStats(boolean withNullMinMax) throws Unknown | |||
| } | |||
| } | |||
|
|
|||
| public void testGeo() { | |||
| Version version = VersionUtils.randomVersionBetween(random(), Version.V_2_0_0, Version.CURRENT); | |||
There was a problem hiding this comment.
Can we test more than one version at a time ? At least one of v2 and one of v5.
nknize
force-pushed
the
fix/24275
branch
4 times, most recently
from
72a8768 to
28ee645
Compare
LegacyGeoPointField was using the wrong decoding for min/max prefix coded GeoPoint Terms. This commit applies the correcct decoding. Note that the min/max values, though, are likely useless anyway since they map to a low resolution morton encoded version of the point; not something that is really of value for field stats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LegacyGeoPointFieldwas using the wrong decoding for min/max prefix coded GeoPoint Terms. This PR applies the correct decoding. Note that the min/max values, though, are likely useless anyway since they map to a low resolution morton encoded version of the point; not something that is really of value for field stats.closes #24275