Remove support for lenient booleans. #26389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
added
:Core/Infra/Settings
danielmitterdorfer
approved these changes
Aug 25, 2017
There was a problem hiding this comment.
Thanks for doing this cleanup @jpountz.
LGTM, I left just one comment.
| @@ -79,7 +79,7 @@ public String name() { | |||
| @Override | |||
| public TokenStream create(TokenStream tokenStream) { | |||
| // fst is null means no synonyms | |||
| return synonymMap.fst == null ? tokenStream : new SynonymGraphFilter(tokenStream, synonymMap, ignoreCase); | |||
| return synonymMap.fst == null ? tokenStream : new SynonymGraphFilter(tokenStream, synonymMap, false); | |||
There was a problem hiding this comment.
Hmm, I see that the field ignoreCase is deprecated but this change looks unrelated to this PR? Looks like you removed this field together with this PR (I think a separate commit would have been better but it's fine with me).
There was a problem hiding this comment.
I'll split into a separate commit
jpountz
force-pushed
the
remove_lenient_booleans
branch
from
e9dff9c to
db28682
Compare
jpountz
force-pushed
the
remove_lenient_booleans
branch
from
db28682 to
36e22bc
Compare
danielmitterdorfer
added a commit
to danielmitterdorfer/elasticsearch
that referenced
this pull request
Oct 15, 2018
With this commit we remove some leftovers from elastic#26389 which cleaned up lenient boolean handling. Relates elastic#26389 Relates elastic#22298
danielmitterdorfer
added a commit
that referenced
this pull request
Oct 16, 2018
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22298