IndexShard.routingEntry should only be updated once all internal state is ready
#26776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasontedor
requested changes
Sep 25, 2017
| @@ -524,6 +523,8 @@ public void onFailure(Exception e) { | |||
| latch.countDown(); | |||
| } | |||
| } | |||
| // set this last, once we finished updating all internal state. | |||
| this.shardRouting = newRouting; | |||
There was a problem hiding this comment.
I think that in the case of a primary this should be published before we countdown the latch that lets the operations that are run under the permit block proceed. At that point we will have published the new primary term but not the new routing entry, and this shard will be used for example in the resync operations. Am I missing something here?
There was a problem hiding this comment.
good catch. Thanks.
|
Thx @s1monw , @jasontedor |
bleskes
added a commit
that referenced
this pull request
Sep 25, 2017
…ate is ready (#26776) The routing entry is used by external components to check whether the shard is ready to perform as primary. Most notably, the peer recovery source handler delays recoveries until the shard routing entry says the shard is ready. When a shard is promoted to primary, we currently update the shard's routing entry before we finish all the work relating to the promotion. This can cause recoveries to fail later on because the `GlobalCheckpointTracker` isn't set (yet) to primary mode. This commit fixes this issue by updating the routing entry last.
bleskes
added a commit
that referenced
this pull request
Sep 25, 2017
…ate is ready (#26776) The routing entry is used by external components to check whether the shard is ready to perform as primary. Most notably, the peer recovery source handler delays recoveries until the shard routing entry says the shard is ready. When a shard is promoted to primary, we currently update the shard's routing entry before we finish all the work relating to the promotion. This can cause recoveries to fail later on because the `GlobalCheckpointTracker` isn't set (yet) to primary mode. This commit fixes this issue by updating the routing entry last.
|
Pinging @elastic/es-core-infra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The routing entry is used by external components to check whether the shard is ready to perform as primary. Most notably, the peer recovery source handler delays recoveries until the shard routing entry says the shard is ready.
When a shard is promoted to primary, we currently update the shard's routing entry before we finish all the work relating to the promotion. This can cause recoveries to fail later on because the
GlobalCheckpointTrackerisn't set (yet) to primary mode.This commit fixes this issue by updating the routing entry last.