Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Fix skip version in yaml test for range fields in query_string #27878

Merged
merged 2 commits into from
Dec 18, 2017

Conversation

cbuescher
Copy link
Member

The mixed cluster test on 6.x are currently failing on range/10_basic rest tests because
they are testing the use of range fields in query_string queries in a mixed cluster with 5.6 nodes.
According to #26552 this feature was only merged to version > 6.1.0

https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+intake/878/

This change moves the test causing these failures to their own test section that can be skipped for versions before 6.1.0

@cbuescher cbuescher added >test-failure Triaged test failures from CI review >test Issues or PRs that are addressing/adding tests v6.1.1 v6.2.0 labels Dec 18, 2017
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one comment about the version.

"Query on range fields in query_string":

- skip:
version: " - 6.1.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be " - 6.0.99"? It looks like the feature is in >= 6.1.0, not > 6.1.0?

@cbuescher
Copy link
Member Author

@jasontedor thanks, I pushed a corrected version

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cbuescher cbuescher merged commit 54c35c6 into elastic:6.x Dec 18, 2017
@cbuescher cbuescher removed the v6.1.1 label Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>test Issues or PRs that are addressing/adding tests >test-failure Triaged test failures from CI v6.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants