[TEST] packaging: function to collect debug info #28608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes when packaging tests fail in CI the test logs aren't enough to tell what went wrong. This routine helps collect more info about the state of the es installation at failure time
andyb-elastic
added
>test
nik9000
approved these changes
Feb 9, 2018
| @@ -415,6 +415,50 @@ stop_elasticsearch_service() { | |||
| fi | |||
| } | |||
|
|
|||
| # the default netcat packages in the distributions we test are not all compatible | |||
There was a problem hiding this comment.
You might want to expand this comment a bit with something like "so we have to use /dev/tcp" or something.
tlrx
approved these changes
Feb 12, 2018
| describe_port() { | ||
| local host="$1" | ||
| local port="$2" | ||
| run test_port "$host" "$port" |
There was a problem hiding this comment.
I'd put this in a local variable, I like the utilities not depend on the run wrapper provided by the bats framework..; wdyt?
| else | ||
| echo "The elasticsearch log doesn't exist at $es_logfile" | ||
|
|
||
| if [ -e "$system_logfile" ]; then |
There was a problem hiding this comment.
Maybe we can always print both logs? We have at least 1 test with 2 nodes and in this case it would only prints the first one.
There was a problem hiding this comment.
I like that idea, I'll make it print both
| tail -n20 /var/log/messages | ||
| fi | ||
| false | ||
| echo "Looks like elasticsearch never started" |
There was a problem hiding this comment.
Can you fix the --tries 120 parameter please? It should be --tries=120
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 15, 2018
* master: Backported synced-flush PR to v5.6.8 and v6.2.2 Move more XContent.createParser calls to non-deprecated version (elastic#28672) Move more XContent.createParser calls to non-deprecated version (elastic#28670) Build: Group archive and package distribution projects (elastic#28673) [DOCS] Add supported token filters [TEST] bump timeout in testFetchShardsSkipUnavailable to 5s Relax remote check for bwc project checkouts (elastic#28666) [TEST] Synchronize searcher list in IndexShardTests [TEST] packaging: function to collect debug info (elastic#28608) Compute declared versions in a static block Docs: Remove references to elasticsearch directory in plugins (elastic#28647) Remove snapshot conditional for bwc snapshots (elastic#28657) Removed redundant JSON object from Put Mapping docs (elastic#28514) Update threadpool.asciidoc target_response_time (elastic#28655)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when packaging tests fail in CI the test logs aren't enough to
tell what went wrong. This routine helps collect more info about the
state of the es installation at failure time