-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REST : Clear Indices Cache API remove deprecated url params #29068
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Pinging @elastic/es-core-infra |
@olcbean, looks good to me! @elasticmachine, test this please. |
Thanks @olcbean! I've merged this to just master. |
public static final ParseField FIELDDATA = new ParseField("fielddata", "field_data"); | ||
public static final ParseField QUERY = new ParseField("query"); | ||
public static final ParseField REQUEST = new ParseField("request"); | ||
public static final ParseField FIELDDATA = new ParseField("fielddata"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at this point using ParseField s for parameters can be replaced with just strings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Do you wanna take it over or should I?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all yours if you have time for it ;)
As discussed in #28943 (comment) and #28866 (comment), the deprecated url parameters should be removed.