-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch many QA projects to use new style requests #30574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In elastic#29623 we added `Request` object flavored requests to the low level REST client and in elastic#30315 we deprecated the the old requests. This changes many calls in the `qa` projects to use the new version.
nik9000
added
>test
Issues or PRs that are addressing/adding tests
review
:Clients/Java Low Level REST Client
Minimal dependencies Java Client for Elasticsearch
v7.0.0
v6.4.0
labels
May 14, 2018
Pinging @elastic/es-core-infra |
javanna
approved these changes
May 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @nik9000
jasontedor
approved these changes
May 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
nik9000
added a commit
that referenced
this pull request
May 16, 2018
Thanks for the reviews @javanna and @jasontedor! I've merged to master and backported to 6.x. |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 16, 2018
…bad-mkay * elastic/6.x: [ML] Wait for ML indices in rolling upgrade tests (elastic#30615) Watcher: Ensure secrets integration tests also run triggered watch (elastic#30478) Move allocation awareness attributes to list setting (elastic#30626) [Docs] Update code snippet in has-child-query.asciidoc (elastic#30510) Allow date math for naming newly-created snapshots (elastic#7939) (elastic#30479) Awaits fix a failing test Switch many QA projects to use new style requests (elastic#30574) QA: System property to override distribution (elastic#30591)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Clients/Java Low Level REST Client
Minimal dependencies Java Client for Elasticsearch
>test
Issues or PRs that are addressing/adding tests
v6.4.0
v7.0.0-beta1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #29623 we added
Request
object flavored requests to the low levelREST client and in #30315 we deprecated the the old requests. This
changes many calls in the
qa
projects to use the new version.