-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Clarify not all PKCS12 usable as truststores #30750
Merged
albertzaharovits
merged 6 commits into
elastic:master
from
albertzaharovits:pkcs12-trustedEntries-docs
May 31, 2018
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c5b5dc7
PKCS12 trusted entry docs
albertzaharovits a1b4d3b
Merge branch 'master' into pkcs12-trustedEntries-docs
albertzaharovits 8d1a228
Specifically mention PKCS12 files and call out the certutil
albertzaharovits a87501f
Added reference to note in 'Encrypting comms'
albertzaharovits bc54f07
Merge branch 'master' into pkcs12-trustedEntries-docs
albertzaharovits e38301d
Fix trustore typo and linking
albertzaharovits File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if the 'pkcs12-trustore-note' link is working correctly here. @lcawl can you please check if this is the proper way to link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albertzaharovits Things are a bit messy at the moment with OSS and X-Pack docs being split across 2 "books".
The
pkcs12-trustore-note
reference is in the ES docs (see https://www.elastic.co/guide/en/elasticsearch/reference/6.2/security-settings.html), but this page is in the X-Pack docs (see https://www.elastic.co/guide/en/elasticsearch/reference/6.2/configuring-tls.html#tls-transport).So you need to do
{ref}/security-settings.html#pkcs12-trustore-note
Can you also fix the spelling on
truststore
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right, with the title in []: {ref}/security-settings.html#pkcs12-trustore-note[specially crafted ones] ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you both for the explanation!