[CCR] Do not unnecessarily wrap fetch exception in a ElasticSearch exception and #33777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ception and
properly map fetch_exception.exception field as object.
The extra caused by level is not necessary here:
```
"fetch_exceptions": [
{
"from_seq_no": 1,
"retries": 106,
"exception": {
"type": "exception",
"reason": "[index1] IndexNotFoundException[no such index]",
"caused_by": {
"type": "index_not_found_exception",
"reason": "no such index",
"index_uuid": "_na_",
"index": "index1"
}
}
}
],
```
martijnvg
added
review
:Distributed Indexing/CCR
|
Pinging @elastic/es-distributed |
|
Just changed exception field mapping to be a type nested by request from @ycombinator |
ycombinator
reviewed
Sep 17, 2018
| @@ -991,7 +991,15 @@ | |||
| "type": "integer" | |||
| }, | |||
| "exception": { | |||
| "type": "text" | |||
| "type": "nested", | |||
There was a problem hiding this comment.
Hey @martijnvg, I was actually wondering if fetch_exceptions (not exception) should be nested as it contains an array of objects. Thoughts?
There was a problem hiding this comment.
@ycombinator I pushed: 1797b73
ycombinator
approved these changes
Sep 17, 2018
martijnvg
added a commit
that referenced
this pull request
Sep 17, 2018
…ception and (#33777) * [CCR] Do not unnecessarily wrap fetch exception in a ElasticSearch exception and properly map fetch_exception.exception field as object. The extra caused by level is not necessary here: ``` "fetch_exceptions": [ { "from_seq_no": 1, "retries": 106, "exception": { "type": "exception", "reason": "[index1] IndexNotFoundException[no such index]", "caused_by": { "type": "index_not_found_exception", "reason": "no such index", "index_uuid": "_na_", "index": "index1" } } } ], ```
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
properly map fetch_exception.exception field as object.
The extra
caused_bylevel is not necessary here: