[Zen2] Logging improvements in CoordinatorTests #33991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today, we know that CoordinatorTests sometimes fail to stabilise due to an election collision. This change improves the logging that occurs when an election collision occurs so it will be easier to see if this is happening when analysing a test failure. We also wrap the call to masterService.submitStateUpdateTask() in a context that logs the node on which it runs. We also introduce the InitialJoinAccumulator instead of using a placeholder CandidateJoinAccumulator at startup, which reduces the cases to consider in CandidateJoinAccumulator.close() and tightens up the assertions we can make here.
DaveCTurner
added
>non-issue
v7.0.0
:Distributed Coordination/Cluster Coordination
|
Pinging @elastic/es-distributed |
61 tasks
ywelsch
approved these changes
Sep 24, 2018
| logger.debug("handleStartJoin: failed election, discarding {}", joinVotes); | ||
| } else if (startJoinRequest.getSourceNode().equals(localNode) == false) { | ||
| logger.debug("handleStartJoin: standing down as leader, discarding {}", joinVotes); | ||
| } |
There was a problem hiding this comment.
should we also log here when bumping the term as leader? I think all the cases where there are existing votes are interesting.
| public void onFailure(String source, Exception e) { | ||
| logger.debug(() -> new ParameterizedMessage("failed to publish: [{}]", source), e); | ||
| public String toString() { | ||
| return "submitStateUpdateTask: new value [" + value + "]"; |
There was a problem hiding this comment.
why do we need this toString() here? We run it right away and don't log it anywhere.
There was a problem hiding this comment.
Left over from earlier when I was enqueueing it, good point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, we know that CoordinatorTests sometimes fail to stabilise due to an
election collision. This change improves the logging that occurs when an
election collision occurs so it will be easier to see if this is happening when
analysing a test failure. We also wrap the call to
masterService.submitStateUpdateTask() in a context that logs the node on which
it runs.
We also introduce the InitialJoinAccumulator instead of using a placeholder
CandidateJoinAccumulator at startup, which reduces the cases to consider in
CandidateJoinAccumulator.close() and tightens up the assertions we can make
here.