Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes fast vector highlighter docs per issue #24318. #34190

Merged
merged 1 commit into from
Nov 8, 2018

Conversation

j-haj
Copy link
Contributor

@j-haj j-haj commented Oct 1, 2018

The fvh highlighter does not support span queries. This fix updates
the docs to add a warning stating the lack of span query support for
fvh. Fixes #24318

The `fvh` highlighter does not support span queries. This fix updates
the docs to add a warning stating the lack of span query support for
`fvh`.
@j-haj j-haj changed the title Fixes fast vector highlighter docs per issue 24318. Fixes fast vector highlighter docs per issue #24318. Oct 1, 2018
@mayya-sharipova mayya-sharipova added >docs General docs changes :Search Relevance/Highlighting How a query matched a document labels Oct 1, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@mayya-sharipova mayya-sharipova self-requested a review October 1, 2018 18:19
@mayya-sharipova
Copy link
Contributor

@elasticmachine test this please

@cbuescher
Copy link
Member

@mayya-sharipova this looks ready for merging. I'll go ahead and merge it with master and 6.x, 6.5. Please let me know if I should backport any further than that.

@cbuescher cbuescher merged commit d00b23c into elastic:master Nov 8, 2018
cbuescher pushed a commit that referenced this pull request Nov 8, 2018
The `fvh` highlighter does not support span queries. This fix updates
the docs to add a warning stating the lack of span query support for
`fvh`.
cbuescher pushed a commit that referenced this pull request Nov 8, 2018
The `fvh` highlighter does not support span queries. This fix updates
the docs to add a warning stating the lack of span query support for
`fvh`.
@cbuescher
Copy link
Member

Merged. Thanks @j-haj for this contribution to the docs.

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Nov 8, 2018
* elastic/master: (25 commits)
  Fixes fast vector highlighter docs per issue 24318. (elastic#34190)
  [ML] Prevent notifications on deletion of a non existent job (elastic#35337)
  [CCR] Auto follow Coordinator fetch cluster state in system context (elastic#35120)
  Mute test for elastic#35361
  Preserve `date_histogram` format when aggregating on unmapped fields (elastic#35254)
  Test: Mute failing SSL test
  Allow unmapped fields in composite aggregations (elastic#35331)
  [RCI] Add IndexShardOperationPermits.asyncBlockOperations(ActionListener<Releasable>) (elastic#34902)
  HLRC: reindex API with wait_for_completion false (elastic#35202)
  Add docs on JNA temp directory not being noexec (elastic#35355)
  [CCR] Adjust list of dynamic index settings that should be replicated (elastic#35195)
  Replicate index settings to followers (elastic#35089)
  Rename RealmConfig.globalSettings() to settings() (elastic#35330)
  [TEST] Cleanup FileUserPasswdStoreTests (elastic#35329)
  Scripting: Add back lookup vars in score script (elastic#34833)
  watcher: Fix integration tests to ensure correct start/stop of Watcher (elastic#35271)
  Remove ALL shard check in CheckShrinkReadyStep (elastic#35346)
  Use soft-deleted docs to resolve strategy for engine operation (elastic#35230)
  [ILM] Check shard and relocation status in AllocationRoutedStep (elastic#35316)
  Ignore date ranges containing 'now' when pre-processing a percolator query (elastic#35160)
  ...
@colings86 colings86 added v6.5.0 and removed v6.5.1 labels Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search Relevance/Highlighting How a query matched a document v6.5.0 v6.6.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fast vector highlighting span queries for nested documents
5 participants