-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: remove possibly unnecessary rollup job logging #34883
Merged
imotov
merged 2 commits into
elastic:master
from
imotov:remove-unncessary-logging-in-rollup
Oct 26, 2018
Merged
Tests: remove possibly unnecessary rollup job logging #34883
imotov
merged 2 commits into
elastic:master
from
imotov:remove-unncessary-logging-in-rollup
Oct 26, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that this statement is a debug leftover since it currently adds an error message `{"jobs":[]}` after each successful REST test.
imotov
added
>test
Issues or PRs that are addressing/adding tests
v7.0.0
:StorageEngine/Rollup
Turn fine-grained time-based data into coarser-grained data
v6.6.0
v6.5.1
labels
Oct 25, 2018
Pinging @elastic/es-search-aggs |
nik9000
approved these changes
Oct 25, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
retest this please |
…logging-in-rollup
retest this please |
polyfractal
approved these changes
Oct 26, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @imotov :)
imotov
added a commit
that referenced
this pull request
Oct 26, 2018
It seems that this statement is a debug leftover since it currently adds an error message `{"jobs":[]}` after each successful REST test.
imotov
added a commit
that referenced
this pull request
Oct 26, 2018
It seems that this statement is a debug leftover since it currently adds an error message `{"jobs":[]}` after each successful REST test.
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
It seems that this statement is a debug leftover since it currently adds an error message `{"jobs":[]}` after each successful REST test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:StorageEngine/Rollup
Turn fine-grained time-based data into coarser-grained data
>test
Issues or PRs that are addressing/adding tests
v6.5.0
v6.6.0
v7.0.0-beta1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that this statement is a debug leftover since it currently
adds an error message
{"jobs":[]}
after each successful REST test.