Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: remove possibly unnecessary rollup job logging #34883

Merged
merged 2 commits into from
Oct 26, 2018

Conversation

imotov
Copy link
Contributor

@imotov imotov commented Oct 25, 2018

It seems that this statement is a debug leftover since it currently
adds an error message {"jobs":[]} after each successful REST test.

It seems that this statement is a debug leftover since it currently
adds an error message `{"jobs":[]}` after each successful REST test.
@imotov imotov added >test Issues or PRs that are addressing/adding tests v7.0.0 :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data v6.6.0 v6.5.1 labels Oct 25, 2018
@imotov imotov requested a review from polyfractal October 25, 2018 20:37
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@imotov
Copy link
Contributor Author

imotov commented Oct 25, 2018

retest this please

@imotov
Copy link
Contributor Author

imotov commented Oct 26, 2018

retest this please

Copy link
Contributor

@polyfractal polyfractal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @imotov :)

@imotov imotov merged commit 02a342e into elastic:master Oct 26, 2018
imotov added a commit that referenced this pull request Oct 26, 2018
It seems that this statement is a debug leftover since it currently
adds an error message `{"jobs":[]}` after each successful REST test.
imotov added a commit that referenced this pull request Oct 26, 2018
It seems that this statement is a debug leftover since it currently
adds an error message `{"jobs":[]}` after each successful REST test.
kcm pushed a commit that referenced this pull request Oct 30, 2018
It seems that this statement is a debug leftover since it currently
adds an error message `{"jobs":[]}` after each successful REST test.
@colings86 colings86 added v6.5.0 and removed v6.5.1 labels Nov 2, 2018
@imotov imotov deleted the remove-unncessary-logging-in-rollup branch May 1, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data >test Issues or PRs that are addressing/adding tests v6.5.0 v6.6.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants