Add dedicated step for checking shrink allocation status #35161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new step for checking whether an index is allocated correctly based on the rules added prior to running the shrink step. It also fixes a bug where for shrink we are not allowed to have the shards relocating for the shrink step. Resolves elastic#34938
dakrone
added
WIP
:Data Management/ILM+SLM
|
Pinging @elastic/es-core-infra |
…rink-allocation-check
…rink-allocation-check
colings86
requested changes
Nov 2, 2018
| int allocationPendingAllShards = 0; | ||
|
|
||
| ImmutableOpenIntMap<IndexShardRoutingTable> allShards = clusterState.getRoutingTable().index(index).getShards(); | ||
| for (ObjectCursor<IndexShardRoutingTable> shardRoutingTable : allShards.values()) { | ||
| int allocationPendingThisShard = 0; | ||
| int shardCopiesThisShard = shardRoutingTable.value.size(); | ||
| for (ShardRouting shardRouting : shardRoutingTable.value.shards()) { | ||
| String currentNodeId = shardRouting.currentNodeId(); | ||
| boolean canRemainOnCurrentNode = ALLOCATION_DECIDERS | ||
| .canRemain(shardRouting, clusterState.getRoutingNodes().node(currentNodeId), allocation) | ||
| .type() == Decision.Type.YES; | ||
| if (canRemainOnCurrentNode == false) { |
There was a problem hiding this comment.
We need to add a check for the shard being started here too otherwise we will end up with the same issue on the allocate action but it will be harder to diagnose
There was a problem hiding this comment.
I'd like to address that in a separate PR, since I think it warrants more testing for the full ramifications, would that be okay with you?
There was a problem hiding this comment.
ok, could you create an issue so we can track the extra work and it doesn't get missed?
colings86
approved these changes
Nov 5, 2018
| int allocationPendingAllShards = 0; | ||
|
|
||
| ImmutableOpenIntMap<IndexShardRoutingTable> allShards = clusterState.getRoutingTable().index(index).getShards(); | ||
| for (ObjectCursor<IndexShardRoutingTable> shardRoutingTable : allShards.values()) { | ||
| int allocationPendingThisShard = 0; | ||
| int shardCopiesThisShard = shardRoutingTable.value.size(); | ||
| for (ShardRouting shardRouting : shardRoutingTable.value.shards()) { | ||
| String currentNodeId = shardRouting.currentNodeId(); | ||
| boolean canRemainOnCurrentNode = ALLOCATION_DECIDERS | ||
| .canRemain(shardRouting, clusterState.getRoutingNodes().node(currentNodeId), allocation) | ||
| .type() == Decision.Type.YES; | ||
| if (canRemainOnCurrentNode == false) { |
There was a problem hiding this comment.
ok, could you create an issue so we can track the extra work and it doesn't get missed?
dakrone
added a commit
that referenced
this pull request
Nov 5, 2018
This adds a new step for checking whether an index is allocated correctly based on the rules added prior to running the shrink step. It also fixes a bug where for shrink we are not allowed to have the shards relocating for the shrink step. This also allows us to simplify AllocationRoutedStep and provide better feedback in the step info for why either the allocation or the shrink checks have failed. Resolves #34938
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Nov 6, 2018
This is a follow-up from elastic#35161 where we now check for started and relocating state in `AllocationRoutedStep`. Resolves elastic#35258
dakrone
added a commit
that referenced
this pull request
Nov 7, 2018
dakrone
added a commit
that referenced
this pull request
Nov 7, 2018
pgomulka
pushed a commit
to pgomulka/elasticsearch
that referenced
this pull request
Nov 13, 2018
…tic#35316) * [ILM] Check shard and relocation status in AllocationRoutedStep This is a follow-up from elastic#35161 where we now check for started and relocating state in `AllocationRoutedStep`. Resolves elastic#35258
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new step for checking whether an index is allocated correctly based
on the rules added prior to running the shrink step. It also fixes a bug where
for shrink we are not allowed to have the shards relocating for the shrink step.
This also allows us to simplify AllocationRoutedStep and provide better
feedback in the step info for why either the allocation or the shrink checks
have failed.
Resolves #34938