Zen2: Move disruption tests to Zen2 #35724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
added
>non-issue
v7.0.0
:Distributed Coordination/Cluster Coordination
|
Pinging @elastic/es-distributed |
61 tasks
DaveCTurner
approved these changes
Nov 21, 2018
| FollowersChecker.FOLLOWER_CHECK_RETRY_COUNT_SETTING, | ||
| LeaderChecker.LEADER_CHECK_TIMEOUT_SETTING, | ||
| LeaderChecker.LEADER_CHECK_INTERVAL_SETTING, | ||
| LeaderChecker.LEADER_CHECK_RETRY_COUNT_SETTING, |
| return nodes; | ||
| } | ||
|
|
||
| protected void clearTemporalResponses() { |
There was a problem hiding this comment.
This thing is weird: it clears out the received pings from a single randomly-chosen node in the cluster. It was weird before this change too. But it will go away soon.
There was a problem hiding this comment.
I agree it's weird. I did not think it was worth investigating further there because this is going away soon.
| () -> { | ||
| final Discovery discovery = internalCluster().getInstance(Discovery.class, node); | ||
| if (discovery instanceof ZenDiscovery) { | ||
| return !((ZenDiscovery) discovery).joiningCluster(); |
There was a problem hiding this comment.
☠️ == false
But it will go away soon.
|
Thanks @DaveCTurner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.put(TestZenDiscovery.USE_ZEN2.getKey(), true)from tests where Zen2 is now enabled by default through the parent test classQuorumGatewayITback to Zen1, as it is not stable with Zen2 as it currently relies on dangling indices due to the lack of proper CS persistence, which triggers secondary failures