Add rest_total_hits_as_int in the search APIs #35848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimczi
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search |
|
test this please |
This change adds the support for a search query parameter named `rest_total_hits_as_int`. This parameter will be used in the next major version (7.0) to restore the total hits as a number in the response. This param is added in this version (6.x) to handle mixed cluster queries where nodes are in multiple versions (7.0 and 6.latest). The param does not change anything in 6x since total hits is always a number in 6x so it is just ignored.
jimczi
force-pushed
the
rest_total_hit_as_int_6x
branch
from
b645521 to
eb3e82e
Compare
jpountz
approved these changes
Nov 26, 2018
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Nov 29, 2018
The support for rest_total_hits_as_int has already been merged to 6x in elastic#35848 so this change adds this new option to master. The plan was to add this new option as part of elastic#35848 but we've decided to wait a few days before merging this breaking change so this commit just handles the new option as a noop exactly like 6x for now. This will allow users to migrate to this parameter before elastic#35848 is merged. Relates elastic#33028
jimczi
added a commit
that referenced
this pull request
Nov 29, 2018
The support for rest_total_hits_as_int has already been merged to 6x in #35848 so this change adds this new option to master. The plan was to add this new option as part of #35848 but we've decided to wait a few days before merging this breaking change so this commit just handles the new option as a noop exactly like 6x for now. This will allow users to migrate to this parameter before #35848 is merged. Relates #33028
jrodewig
pushed a commit
that referenced
this pull request
Jan 16, 2020
With #35848, users can now retrieve total hits as an integer when the `rest_total_hits_as_int` query parameter is `true`. This is the default value. This updates several snippet examples in the Watcher docs that used a workaround to get a total hits integer.
jrodewig
pushed a commit
that referenced
this pull request
Jan 16, 2020
With #35848, users can now retrieve total hits as an integer when the `rest_total_hits_as_int` query parameter is `true`. This is the default value. This updates several snippet examples in the Watcher docs that used a workaround to get a total hits integer.
jrodewig
pushed a commit
that referenced
this pull request
Jan 16, 2020
With #35848, users can now retrieve total hits as an integer when the `rest_total_hits_as_int` query parameter is `true`. This is the default value. This updates several snippet examples in the Watcher docs that used a workaround to get a total hits integer.
jrodewig
pushed a commit
that referenced
this pull request
Jan 16, 2020
With #35848, users can now retrieve total hits as an integer when the `rest_total_hits_as_int` query parameter is `true`. This is the default value. This updates several snippet examples in the Watcher docs that used a workaround to get a total hits integer.
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
With elastic#35848, users can now retrieve total hits as an integer when the `rest_total_hits_as_int` query parameter is `true`. This is the default value. This updates several snippet examples in the Watcher docs that used a workaround to get a total hits integer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the support for a search query parameter named
rest_total_hits_as_int.This parameter will be used in the next major version (7.0) to restore the total hits as a number
in the response. This param is added in this version (6.x) to handle mixed cluster queries where nodes
are in multiple versions (7.0 and 6.latest). The param does not change anything in 6x since total hits
is always a number in 6x so it is just ignored.
Relates #33028