-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HLRC] Added support for CCR Get Auto Follow Pattern apis #36049
[HLRC] Added support for CCR Get Auto Follow Pattern apis #36049
Conversation
This change also adds documentation for the Get Auto Follow Pattern API. Relates to elastic#33824
Pinging @elastic/es-core-features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
heh you know the HLRC PR process well now. Great work.
This change also adds documentation for the Get Auto Follow Pattern API. Relates to #33824
The current response format is: ``` { "pattern1": { ... }, "pattern2": { ... } } ``` The new format is: ``` { "patterns": [ { "name": "pattern1", "pattern": { ... } }, { "name": "pattern2", "pattern": { ... } } ] } ``` This format is more structured and more friendly for parsing and generating specs. This is a breaking change, but it is better to do this now while ccr is still a beta feature than later. Follow up from elastic#36049
This change also adds documentation for the Get Auto Follow Pattern API. Relates to #33824
The current response format is: ``` { "pattern1": { ... }, "pattern2": { ... } } ``` The new format is: ``` { "patterns": [ { "name": "pattern1", "pattern": { ... } }, { "name": "pattern2", "pattern": { ... } } ] } ``` This format is more structured and more friendly for parsing and generating specs. This is a breaking change, but it is better to do this now while ccr is still a beta feature than later. Follow up from #36049
The current response format is: ``` { "pattern1": { ... }, "pattern2": { ... } } ``` The new format is: ``` { "patterns": [ { "name": "pattern1", "pattern": { ... } }, { "name": "pattern2", "pattern": { ... } } ] } ``` This format is more structured and more friendly for parsing and generating specs. This is a breaking change, but it is better to do this now while ccr is still a beta feature than later. Follow up from #36049
Hi @martijnvg, this appears to be a breaking change in the response format between versions Examples:
We have a mechanism by which we can workaround this breaking change in the .NET client (a custom derserializer), but I wanted to check the reasoning behind this change? Are there any intentions to add sibling json nodes to the "patterns" node? Thanks! |
Hey @codebrain This breaking change was part of #36203, which also describes the reasoning.
No, at the moment there are no plans for this. But this will allow us to do so in the future if needed. |
This change also adds documentation for the Get Auto Follow Pattern API.
Relates to #33824