Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation check for No Master Block setting #38383

Merged
merged 5 commits into from
Feb 5, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Review feedback for Node checks
gwbrown committed Feb 5, 2019
commit 83916ff25f87a52aa76c536223c6c129ad7b2fe6
Original file line number Diff line number Diff line change
@@ -50,8 +50,9 @@ static DeprecationIssue noMasterBlockRenamed(Settings nodeSettings, PluginsAndMo
return new DeprecationIssue(DeprecationIssue.Level.CRITICAL,
"Master block setting renamed",
"https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-7.0.html" +
"_new_name_for_literal_no_maaster_block_literal_setting",
"The settings discovery.zen.no_master_block has been renamed to cluster.no_master_block");
"_new_name_for_literal_no_master_block_literal_setting",
"The setting discovery.zen.no_master_block will be renamed to cluster.no_master_block in 7.0. " +
"Please unset discovery.zen.no_master_block and set cluster.no_master_block after upgrading to 7.0.");
}
return null;
}
Original file line number Diff line number Diff line change
@@ -89,8 +89,9 @@ public void testNoMasterBlockRenamed() {
DeprecationIssue expected = new DeprecationIssue(DeprecationIssue.Level.CRITICAL,
"Master block setting renamed",
"https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-7.0.html" +
"_new_name_for_literal_no_maaster_block_literal_setting",
"The settings discovery.zen.no_master_block has been renamed to cluster.no_master_block");
"_new_name_for_literal_no_master_block_literal_setting",
"The setting discovery.zen.no_master_block will be renamed to cluster.no_master_block in 7.0. " +
"Please unset discovery.zen.no_master_block and set cluster.no_master_block after upgrading to 7.0.");

assertSettingsAndIssue(NO_MASTER_BLOCK_SETTING.getKey(), randomFrom("all", "write"), expected);
}