[DOC][SQL JDBC]change setup URL #38564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I read the following sources and thought that it was necessary to change the documentation of [SQL JDBC]. change setup URL「?」→「://」 https://github.com/elastic/elasticsearch/blob/6857d305270be3d987689fda37cc84b7bc18fbb3/x-pack/plugin/sql/qa/security/src/test/java/org/elasticsearch/xpack/sql/qa/security/JdbcSecurityIT.java
|
Pinging @elastic/es-search |
|
Thank you for your PR. The fix is partially correct: the extra Can you please adjust accordingly? Thank you. |
added 2 commits
February 13, 2019 10:59
change setup URL Option 「[http|https]://」→「[[http|https]://]」
change setup URL Option Reflect error.
|
@costin |
change setup URL Option Reflect error.
astefan
pushed a commit
that referenced
this pull request
Feb 14, 2019
(cherry picked from commit 103786e)
astefan
pushed a commit
that referenced
this pull request
Feb 14, 2019
(cherry picked from commit 103786e)
astefan
pushed a commit
that referenced
this pull request
Feb 14, 2019
(cherry picked from commit 103786e)
astefan
pushed a commit
that referenced
this pull request
Feb 14, 2019
(cherry picked from commit 103786e)
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 14, 2019
* elastic/master: Remove immediate operation retry after mapping update (elastic#38873) Remove mentioning of types from bulk API docs (elastic#38896) SQL: change JDBC setup URL in the documentation (elastic#38564) Skip BWC tests in checkPart1 and checkPart2 (elastic#38730) Enable silent FollowersCheckerTest (elastic#38851) Update TESTING.asciidoc with platform specific instructions (elastic#38802) Use consistent view of realms for authentication (elastic#38815) Stabilize RareClusterState (elastic#38671) Increase Timeout in UnicastZenPingTests (elastic#38893) Do not recommend installing vagrant-winrm elastic#38887 _cat/indices with Security, hide names when wildcard (elastic#38824) SQL: fall back to using the field name for column label (elastic#38842) Fix LocalIndexFollowingIT#testRemoveRemoteConnection() test (elastic#38709) Remove joda time mentions in documentation (elastic#38720) Add enabled status for token and api key service (elastic#38687)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I read the following sources and thought that it was necessary to change the documentation of [SQL JDBC].
change setup URL「?」→「://」
https://github.com/elastic/elasticsearch/blob/6857d305270be3d987689fda37cc84b7bc18fbb3/x-pack/plugin/sql/qa/security/src/test/java/org/elasticsearch/xpack/sql/qa/security/JdbcSecurityIT.java