[ML-DataFrame] Dataframe REST cleanups #39451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core |
droberts195
reviewed
Feb 27, 2019
| assertEquals("body_id", dataFrameTransformConfig.getId()); | ||
|
|
||
| expectThrows(IllegalArgumentException.class, | ||
| () -> createDataFrameTransformConfigFromString(pivotTransform, "other_id")); |
There was a problem hiding this comment.
You could also assert that the error message is as expected here. (For example this will detect if the body ID and URL ID are the wrong way around when the error message is formed.)
benwtrent
approved these changes
Feb 27, 2019
| import java.io.IOException; | ||
| import java.util.Map; | ||
|
|
||
| public class DataFrameGetAndGetStatsIT extends DataFrameRestTestCase { |
There was a problem hiding this comment.
nit: All these tests seem like they could just be yml tests.
hendrikmuhs
force-pushed
the
dataframe-cleanups
branch
from
bedf97f to
a1ab5c9
Compare
|
opened: #39497 (fails locally for a master build without this PR, therefore unrelated) |
|
run elasticsearch-ci/1 |
hendrikmuhs
pushed a commit
to hendrikmuhs/elasticsearch
that referenced
this pull request
Feb 28, 2019
fix a couple of odd behaviors of data frame transforms REST API's: - check if id from body and id from URL match if both are specified - do not allow a body for delete - allow get and stats without specifying an id
hendrikmuhs
pushed a commit
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix a couple of odd behaviors of data frame transforms REST API's: