Allow inclusion of unloaded segments in stats #39512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we have no chance to fetch actual segment stats for segments that are currently unloaded. This is relevant in the case of frozen indices. This allows to monitor how much memory a frozen index would use if it was unfrozen.
s1monw
added
>enhancement
:Distributed Indexing/Engine
|
Pinging @elastic/es-distributed |
dnhatn
approved these changes
Feb 28, 2019
| this.stats = new SegmentsStats(); | ||
| for (LeafReaderContext ctx : reader.getContext().leaves()) { | ||
| SegmentReader segmentReader = Lucene.segmentReader(ctx.reader()); | ||
| fillSegmentStats(segmentReader, true, stats); |
| @@ -207,7 +207,7 @@ public CommonStats(IndicesQueryCache indicesQueryCache, IndexShard indexShard, C | |||
| completion = indexShard.completionStats(flags.completionDataFields()); | |||
| break; | |||
| case Segments: | |||
| segments = indexShard.segmentStats(flags.includeSegmentFileSizes()); | |||
| segments = indexShard.segmentStats(flags.includeSegmentFileSizes(),flags.includeUnloadedSegments()); | |||
ywelsch
approved these changes
Mar 1, 2019
sounds good to me. I will open a second PR for this. |
s1monw
added a commit
that referenced
this pull request
Mar 5, 2019
Today we have no chance to fetch actual segment stats for segments that are currently unloaded. This is relevant in the case of frozen indices. This allows to monitor how much memory a frozen index would use if it was unfrozen.
s1monw
added a commit
that referenced
this pull request
Mar 5, 2019
s1monw
added a commit
that referenced
this pull request
Mar 5, 2019
s1monw
added a commit
to s1monw/elasticsearch
that referenced
this pull request
Mar 5, 2019
Today we don't return segments stats for closed indices which makes it hard to tell how much memory such an index would require. With this change we return the statistics if requested by setting `include_unloaded_segments` to true on the rest request. Relates to elastic#39512/
This was referenced Mar 8, 2019
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we have no chance to fetch actual segment stats for segments that
are currently unloaded. This is relevant in the case of frozen indices.
This allows to monitor how much memory a frozen index would use if it was
unfrozen.