Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify from and size as querystring parameters #40575

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Mar 28, 2019

This PR updates the header for from and size to indicate
that they can be specified as querystring parameters.

This commit updates the header for from and size to indicate
that they can be specified as querystring parameters.
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkyle davidkyle added the :ml Machine learning label Mar 28, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@davidkyle davidkyle added the >docs General docs changes label Mar 28, 2019
@davidkyle davidkyle merged commit e37dc6c into 6.7 Apr 29, 2019
davidkyle pushed a commit that referenced this pull request Apr 29, 2019
This commit updates the header for from and size to indicate
that they can be specified as querystring parameters.
@davidkyle
Copy link
Member

This one has been open for a while, @russcam I went ahead and merged it

davidkyle pushed a commit that referenced this pull request Apr 29, 2019
This commit updates the header for from and size to indicate
that they can be specified as querystring parameters.
@russcam
Copy link
Contributor Author

russcam commented Apr 29, 2019

Thanks for merging @davidkyle 👍

@jaymode jaymode added v7.0.1 and removed v7.0.2 labels Apr 29, 2019
akhil10x5 pushed a commit to akhil10x5/elasticsearch that referenced this pull request May 2, 2019
This commit updates the header for from and size to indicate
that they can be specified as querystring parameters.
@jakelandis jakelandis added v6.8.0 and removed v6.7.3 labels May 3, 2019
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
This commit updates the header for from and size to indicate
that they can be specified as querystring parameters.
@colings86 colings86 deleted the russcam-patch-13 branch May 27, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants