Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix FullClusterRestart tests now that 7.0.0 can be an "oldCluster" #41224

Closed
wants to merge 8 commits into from

Conversation

jakelandis
Copy link
Contributor

Now that 7.0.0 can be an "old" cluster the following needs to be updated:

This commit favors using the non-deprecrated and typeless APIs if the
"old" cluster is 7.0.0 or greater, and thus all of the relevant expected
depreciations are removed.

closes: #41222

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks similar to problems that we faced in 7.x and master already (which makes sense as full-cluster restart there would be running against these versions). Rather than re-do that work, can be we bring back work that was already done on 7.x or master so that these branches look roughly the same?

@colings86 colings86 added the :Delivery/Build Build or test infrastructure label Apr 16, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@jakelandis
Copy link
Contributor Author

This looks similar to problems that we faced in 7.x and master already (which makes sense as full-cluster restart there would be running against these versions). Rather than re-do that work, can be we bring back work that was already done on 7.x or master so that these branches look roughly the same?

doh! I should have looked at the newer branches before starting this. A quick glance and the two changes are very similar. I will close this PR and backport the 7.x version.

@jakelandis jakelandis closed this Apr 16, 2019
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants