Ensure a unique WatchId for tests in SmokeTestWatcherWithSecurityIT #41659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit un-mutes SmokeTestWatcherWithSecurityIT by ensuring that between test invocations a new WatchId is used. It is believed that since the same WatchId is used between tests, and that Watch is never deleted, the test failures may be due to a race condition between the current Watch execution, the new Watch (with the same ID), and the busy wait for the Watcher history document. This race condtion can be avoided by simply using a new WatchId and removing the Watch between test invocations. This commit also adds a minor change (XPackRestTestConstants.TEMPLATE_NAMES_NO_ILM) that is needed since the test was muted. Fixes elastic#35361
jakelandis
changed the title
|
closing in favor of #41765 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit un-mutes SmokeTestWatcherWithSecurityIT by ensuring that between test invocations
a new WatchId is used. It is believed that since the same WatchId is used between tests,
and that Watch is never deleted, the test failures may be due to a race condition between
the current Watch execution, the new Watch (with the same ID), and the busy wait for the
Watcher history document.
This race condtion can be avoided by simply using a new WatchId and removing the Watch
between test invocations.
This commit also adds a minor change (XPackRestTestConstants.TEMPLATE_NAMES_NO_ILM) that is
needed since the test was muted.
Fixes #35361
Fixes #30777
Fixes #35361
Fixes #33291
Fixes #29893
Draft PR to manually run this through CI a few times.