Fix sorting on nested field with unmapped #42451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously sorting on a missing nested field would fail with an Exception: `[nested_field] failed to find nested object under path [nested_path]` despite `unmapped_type` being set on the query. Fixes: elastic#33644
matriv
added
:Search/Search
|
Pinging @elastic/es-search |
|
Tried to add some unit test for this, but it's quite difficult because of the mocked |
jimczi
approved these changes
May 24, 2019
| throw new QueryShardException(context, | ||
| "max_children is only supported on last level of nested sort"); | ||
| Nested nested = null; | ||
| if (!isUnmapped) { |
There was a problem hiding this comment.
nit: we have a convention to use isUnmapped == false for readability.
| .addSort(SortBuilders.fieldSort("nested.foo").unmappedType("keyword") | ||
| .setNestedSort(new NestedSortBuilder("nested").setNestedSort(new NestedSortBuilder("nested.foo")))) | ||
| .get(); | ||
| assertNoFailures(searchResponse); |
There was a problem hiding this comment.
Can you add a test with a nested query ?
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Previously sorting on a missing nested field would fail with an Exception: `[nested_field] failed to find nested object under path [nested_path]` despite `unmapped_type` being set on the query. Fixes: elastic#33644
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously sorting on a missing nested field would fail with an
Exception:
[nested_field] failed to find nested object under path [nested_path]despite
unmapped_typebeing set on the query.Fixes: #33644