scheduleAtFixedRate would hang #42993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Though not in use in elasticsearch currently, it seems surprising that ThreadPool.scheduler().scheduleAtFixedRate would hang. A recurring scheduled task is never completed (except on failure) and we test for exceptions using RunnableFuture.get(), which hangs for periodic tasks. Fixed by checking that task is done before calling .get(). Related to elastic#38441
henningandersen
added
>bug
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
ywelsch
suggested changes
Jun 11, 2019
| @@ -276,7 +277,11 @@ protected void afterExecute(Runnable r, Throwable t) { | |||
| if (t != null) return; | |||
| // Scheduler only allows Runnable's so we expect no checked exceptions here. If anyone uses submit directly on `this`, we | |||
| // accept the wrapped exception in the output. | |||
| ExceptionsHelper.reThrowIfNotNull(EsExecutors.rethrowErrors(r)); | |||
| if (r instanceof RunnableFuture && ((RunnableFuture<?>) r).isDone()) { | |||
There was a problem hiding this comment.
should we move the isDone condition to EsExecutors.rethrowErrors instead? Or should we alternatively assert isDone there? This will possibly cover other (and future) occurrences of this as well
There was a problem hiding this comment.
I added the assertion in 3781c31, since moving the check to EsExecutors.rethrowErrors would mean that we would silently ignore if isDone was false also for non scheduled cases.
|
Thanks @ywelsch , this is ready for another round. |
…ule_at_fixed_rate_deadlock
henningandersen
added a commit
that referenced
this pull request
Jun 11, 2019
Though not in use in elasticsearch currently, it seems surprising that ThreadPool.scheduler().scheduleAtFixedRate would hang. A recurring scheduled task is never completed (except on failure) and we test for exceptions using RunnableFuture.get(), which hangs for periodic tasks. Fixed by checking that task is done before calling .get().
henningandersen
added a commit
that referenced
this pull request
Jun 11, 2019
Though not in use in elasticsearch currently, it seems surprising that ThreadPool.scheduler().scheduleAtFixedRate would hang. A recurring scheduled task is never completed (except on failure) and we test for exceptions using RunnableFuture.get(), which hangs for periodic tasks. Fixed by checking that task is done before calling .get().
henningandersen
added a commit
that referenced
this pull request
Jun 11, 2019
Though not in use in elasticsearch currently, it seems surprising that ThreadPool.scheduler().scheduleAtFixedRate would hang. A recurring scheduled task is never completed (except on failure) and we test for exceptions using RunnableFuture.get(), which hangs for periodic tasks. Fixed by checking that task is done before calling .get().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though not in use in elasticsearch currently, it seems surprising that
ThreadPool.scheduler().scheduleAtFixedRate would hang. A recurring
scheduled task is never completed (except on failure) and we test for
exceptions using RunnableFuture.get(), which hangs for periodic tasks.
Fixed by checking that task is done before calling .get().
Related to #38441