Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the client transport profile filter #43236

Merged
merged 2 commits into from
Jul 3, 2019
Merged

Remove the client transport profile filter #43236

merged 2 commits into from
Jul 3, 2019

Conversation

jaymode
Copy link
Member

@jaymode jaymode commented Jun 14, 2019

Now that the transport client has been removed, the client transport
profile filter can be removed from security. This filter prevented node
actions from being executed using a transport client.

@jaymode
Remove the client transport profile filter
62af649 
Now that the transport client has been removed, the client transport
profile filter can be removed from security. This filter prevented node
actions from being executed using a transport client.
@jaymode jaymode requested a review from tvernum June 14, 2019 14:49
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

@jaymode jaymode requested a review from jkakavas June 18, 2019 14:09
tvernum
tvernum approved these changes Jun 20, 2019
View reviewed changes
Copy link
Contributor

@tvernum tvernum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...ity/src/test/java/org/elasticsearch/xpack/security/transport/ServerTransportFilterTests.java
}

private ServerTransportFilter.NodeProfile getNodeFilter(boolean reservedRealmEnabled) throws IOException {
private ServerTransportFilter getNodeFilter() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Rename method?

Suggested change
private ServerTransportFilter getNodeFilter() {
private ServerTransportFilter getTransportFilter() {

jkakavas
jkakavas approved these changes Jun 25, 2019
View reviewed changes
Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvernum
Copy link
Contributor

tvernum commented Jul 3, 2019

@elasticmachine update branch

@tvernum tvernum merged commit 0a41b13 into elastic:master Jul 3, 2019
@jakelandis jakelandis mentioned this pull request Feb 22, 2021
Closed
@masseyke masseyke mentioned this pull request Aug 9, 2021
Closed
80 tasks
@masseyke masseyke mentioned this pull request Aug 26, 2021
Merged
masseyke added a commit that referenced this pull request Sep 2, 2021
@masseyke
Adding deprecation info API check for client transport profile setting (
b95df28 
#76999)

In 8.0, access to the transport client has been removed, so the transport.profiles.*.xpack.security.type
setting is gone. This commit adds a deprecation info API check for this property.
Relates #42404 #43236
@jrodewig jrodewig mentioned this pull request Sep 15, 2021
Merged
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for transport profile types (#77780)
d1ec9ef 
We deprecated the `transport.profiles.*.xpack.security.type` setting in 7.3 with PR #43237
However, we didn't add a related item to the 7.3 deprecation docs. This adds the
missing item.

Relates to #43236.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for transport profile types (#77780) (#77868
a3404c5 
)

We deprecated the `transport.profiles.*.xpack.security.type` setting in 7.3 with PR #43237
However, we didn't add a related item to the 7.3 deprecation docs. This adds the
missing item.

Relates to #43236.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for transport profile types (#77780) (#77869
890efc6 
)

We deprecated the `transport.profiles.*.xpack.security.type` setting in 7.3 with PR #43237
However, we didn't add a related item to the 7.3 deprecation docs. This adds the
missing item.

Relates to #43236.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for transport profile types (#77780) (#77870
24d6285 
)

We deprecated the `transport.profiles.*.xpack.security.type` setting in 7.3 with PR #43237
However, we didn't add a related item to the 7.3 deprecation docs. This adds the
missing item.

Relates to #43236.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for transport profile types (#77780) (#77880
08d7e31 
)

We deprecated the `transport.profiles.*.xpack.security.type` setting in 7.3 with PR #43237
However, we didn't add a related item to the 7.3 deprecation docs. This adds the
missing item.

Relates to #43236.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for transport profile types (#77780) (#77879
ec3f52e 
)

We deprecated the `transport.profiles.*.xpack.security.type` setting in 7.3 with PR #43237
However, we didn't add a related item to the 7.3 deprecation docs. This adds the
missing item.

Relates to #43236.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for transport profile types (#77780) (#77878
3aceb55 
)

We deprecated the `transport.profiles.*.xpack.security.type` setting in 7.3 with PR #43237
However, we didn't add a related item to the 7.3 deprecation docs. This adds the
missing item.

Relates to #43236.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for transport profile types (#77780) (#77877
76bb932 
)

We deprecated the `transport.profiles.*.xpack.security.type` setting in 7.3 with PR #43237
However, we didn't add a related item to the 7.3 deprecation docs. This adds the
missing item.

Relates to #43236.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for transport profile types (#77780) (#77876
7d66883 
)

We deprecated the `transport.profiles.*.xpack.security.type` setting in 7.3 with PR #43237
However, we didn't add a related item to the 7.3 deprecation docs. This adds the
missing item.

Relates to #43236.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for transport profile types (#77780) (#77875
234d99c 
)

We deprecated the `transport.profiles.*.xpack.security.type` setting in 7.3 with PR #43237
However, we didn't add a related item to the 7.3 deprecation docs. This adds the
missing item.

Relates to #43236.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for transport profile types (#77780) (#77874
f77dadb 
)

We deprecated the `transport.profiles.*.xpack.security.type` setting in 7.3 with PR #43237
However, we didn't add a related item to the 7.3 deprecation docs. This adds the
missing item.

Relates to #43236.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for transport profile types (#77780) (#77873
7f9643e 
)

We deprecated the `transport.profiles.*.xpack.security.type` setting in 7.3 with PR #43237
However, we didn't add a related item to the 7.3 deprecation docs. This adds the
missing item.

Relates to #43236.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for transport profile types (#77780) (#77872
6670133 
)

We deprecated the `transport.profiles.*.xpack.security.type` setting in 7.3 with PR #43237
However, we didn't add a related item to the 7.3 deprecation docs. This adds the
missing item.

Relates to #43236.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for transport profile types (#77780) (#77871
40b719c 
)

We deprecated the `transport.profiles.*.xpack.security.type` setting in 7.3 with PR #43237
However, we didn't add a related item to the 7.3 deprecation docs. This adds the
missing item.

Relates to #43236.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkakavas jkakavas jkakavas approved these changes

@tvernum tvernum tvernum approved these changes

Assignees
No one assigned
Labels
>breaking :Security/TLS SSL/TLS, Certificates v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jaymode @elasticmachine @tvernum @jkakavas @jakelandis