Use transport actions instead of guice for xpack info #43449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Xpack info API internally gathers all xpack feature sets by using guice to bind many implementations. The info api then iterates over these feature sets to gather usage information for each. However, since each of these implementations are in different plugins, there is no direct, non-guice way for them to register the implementations. This commit removes the dependence on guice for the info api by having the core xpack jar contain an action instance for each plugin, and the implementation of those actions are then registered within each xpack feature plugin. The info api then iterates over each of these actions and calls them with the NodeClient.
talevy
reviewed
Jun 21, 2019
...plugin/core/src/main/java/org/elasticsearch/xpack/core/action/TransportXPackUsageAction.java
Outdated
Show resolved
Hide resolved
.../core/src/main/java/org/elasticsearch/xpack/core/action/XPackInfoFeatureTransportAction.java
Show resolved
Hide resolved
|
@talevy I addressed your comments. In answer to your question about tests: yes, there are existing tests for all the info action implementations. These are just the feature set tests we had before but renamed. |
talevy
approved these changes
Jun 21, 2019
|
Pinging @elastic/es-core-infra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Xpack info API internally gathers all xpack feature sets by using
guice to bind many implementations. The info api then iterates over
these feature sets to gather usage information for each. However, since
each of these implementations are in different plugins, there is no
direct, non-guice way for them to register the implementations. This
commit removes the dependence on guice for the info api by having the
core xpack jar contain an action instance for each plugin, and the
implementation of those actions are then registered within each xpack
feature plugin. The info api then iterates over each of these actions
and calls them with the NodeClient.